[Qt] optimize helpmessage dialog #5632

jonasschnelli commented at 8:14 PM on January 9, 2015: contributor

enlarge standard size
remove fixed 10px font
remove left mood image
ensure that table has no ugly line-breaks on OSX, Linux

related to #5559

jonasschnelli commented at 8:21 PM on January 9, 2015: contributor

Before: bildschirmfoto 2015-01-09 um 20 09 28 1

bildschirmfoto 2015-01-09 um 20 08 02

After: bildschirmfoto 2015-01-09 um 21 02 18

bildschirmfoto 2015-01-09 um 21 07 41

bildschirmfoto 2015-01-09 um 21 18 56

gmaxwell added the label GUI on Jan 9, 2015

in src/Makefile.qt.include:None in 98c222b5aa outdated

 313 | @@ -314,8 +314,7 @@ BITCOIN_QT_CPP += \
 314 |    qt/walletview.cpp
 315 |  endif
 316 |  
 317 | -RES_IMAGES = \
 318 | -  qt/res/images/about.png
 319 | +RES_IMAGES =

Diapolo commented at 10:33 PM on January 9, 2015:

Not sure, but perhaps remove or comment out that one?

jonasschnelli commented at 7:09 AM on January 10, 2015:

I wasn't sure about that. Maybe we should keep the compile process open for further images. That's why I left it. But I'm not sure.

zander commented at 6:28 AM on January 13, 2015:

I suggest removing it since you now set it to empty; so if someone adds another RES_IMAGES to the top of the file you end up deleting it again with this one.

laanwj commented at 10:25 AM on January 16, 2015:

I'd say keep it empty. If there are images again, they can be added here. There's no need to add another RES_IMAGES to the top of the file.

in src/qt/forms/helpmessagedialog.ui:None in 98c222b5aa outdated

   5 | @@ -6,33 +6,15 @@
   6 |     <rect>
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 | -    <width>585</width>
  10 | -    <height>225</height>
  11 | +    <width>780</width>

Diapolo commented at 10:34 PM on January 9, 2015:

Thanks, I already asked if the resize in the initial pull was done by intention and got a yes. It was too small IMHO, so good one here!

zander commented at 6:30 AM on January 13, 2015: none

looks good to me

fanquake commented at 10:21 AM on January 16, 2015: member

Tested ACK

[Qt] optimize helpmessage dialog

- enlarge standard size
- remove fixed 10px font
- remove left mood image
- ensure that table has no ugly line-breaks on OSX, Linux

41eb252a8c

jonasschnelli force-pushed on Jan 16, 2015

jonasschnelli commented at 10:50 AM on January 16, 2015: contributor

Removed the RES_IMAGES part.

laanwj referenced this in commit 9fe53a85e0 on Jan 16, 2015

laanwj closed this on Jan 16, 2015

DrahtBot locked this on Sep 8, 2021