Coin Control: Use U+2248 "ALMOST EQUAL TO" rather than a simple tilde #5651

luke-jr commented at 10:28 PM on January 12, 2015: member

The tilde appears identical to a negative sign for me:

This changes it to something more obvious:

Coin Control: Use U+2248 "ALMOST EQUAL TO" rather than a simple tilde (which may be mistaken for a negative sign) 1d84aead21

gmaxwell commented at 10:30 PM on January 12, 2015: contributor

I like this, in that even if it fails to display correctly you'll just get a box or a missing symbol or and equals sign; and all are much better failure modes than something that looks like a minus sign.

But I am not a GUI wizard.

Michagogo commented at 10:35 PM on January 12, 2015: contributor

Is falling back to = something that might happen? Also, we need to check the various platforms' default fonts (OS X 10.10, OS X <10.10, Win7, Win8, maybe Unity default, possibly others?) to see if this looks right.

gmaxwell commented at 10:37 PM on January 12, 2015: contributor

@Michagogo falling back? I don't think so... being visually indistinguishable to? probably, but thats not so severe a problem as the 'negative' values.

jonasschnelli commented at 8:02 AM on January 13, 2015: contributor

OSX 10.10 Before: bildschirmfoto 2015-01-13 um 08 57 07

After: bildschirmfoto 2015-01-13 um 08 56 15

Win7: bildschirmfoto 2015-01-13 um 09 01 10

Are there any OS without correct default font utf8 support with a mentionable amount of market share?

Tested ACK.

jonasschnelli commented at 8:04 AM on January 13, 2015: contributor

Just another thought:

why not s/~/aprox.?

Michagogo commented at 8:34 AM on January 13, 2015: contributor

May want to also find someone on Win8+ and an earlier OS X, since I'm pretty sure 10.10 changed the system font.

On Tuesday, January 13, 2015, Jonas Schnelli notifications@github.com wrote:

Just another thought:

why not s/~/aprox.?

— Reply to this email directly or view it on GitHub #5651 (comment).

laanwj added the label GUI on Jan 13, 2015

laanwj commented at 8:59 AM on January 13, 2015: member

@zander \u is c++11 so we can't use it yet. The current formulation makes no assumption about the compiler, and just creates a UTF-8 string in bytes form. The end-result of \u in memory would be the same.

As for the client we explicitly force all string converstions to be UTF-8 at the start of the program (which is the default for Qt5 higher):

#if QT_VERSION < 0x050000
    // Internal string conversion is all UTF-8
    QTextCodec::setCodecForTr(QTextCodec::codecForName("UTF-8"));
    QTextCodec::setCodecForCStrings(QTextCodec::codecForTr());
#endif

That said, QChar(0x2243) looks a bit more readable so I'd prefer that.

Tested ACK anyway.

Diapolo commented at 1:00 PM on January 13, 2015: none

utACK

laanwj commented at 1:51 PM on January 13, 2015: member

@diapolo it'd help moving this forward if you test on windows

Diapolo commented at 2:01 PM on January 13, 2015: none

@laanwj Done, looks good. Tested ACK! Btw. can you help me with pushing the payment request unit tests?

Michagogo commented at 4:38 PM on January 13, 2015: contributor

Looks like on Windows 7, it does show properly (0.10.0rc3 with this cherry-picked on top):

I think I have a Windows 10 Preview VM, if so I'll try installing it there too.

theuni commented at 4:57 PM on January 13, 2015: member

Someone mind checking this in some of the more difficult languages? I believe traditional chinese is one that usually ends up causing us trouble with exotic chars like these.

Michagogo commented at 5:06 PM on January 13, 2015: contributor

Looks fine in zh_CN on Windows 7:

theuni commented at 5:26 PM on January 13, 2015: member

@Michagogo thanks for testing.

Michagogo commented at 5:27 PM on January 13, 2015: contributor

Should still be checked on OS X and the various Linux environments, though.

jonasschnelli commented at 8:46 PM on January 13, 2015: contributor

I did test on OSX10.10 and 10.9 (comparable to Win8 and Win7 in case of actuality): See osx10.10 screenshot above and here also comes the 10.9 screenshot:

bildschirmfoto 2015-01-13 um 21 45 42

theuni commented at 9:09 PM on January 13, 2015: member

Verified looks ok in Ubuntu with qt4 and qt5. Kde/kwin.

Michagogo commented at 9:14 PM on January 13, 2015: contributor

@theuni Uh, I thought Ubuntu is Unity?

On Tue, Jan 13, 2015 at 11:09 PM, Cory Fields notifications@github.com wrote:

Verified looks ok in Ubuntu with qt4 and qt5. Kde/kwin.

— Reply to this email directly or view it on GitHub #5651 (comment).

theuni commented at 9:19 PM on January 13, 2015: member

Only by default.

jonasschnelli commented at 3:38 PM on January 14, 2015: contributor

We should also test this on OSX over a gitian build.

laanwj commented at 9:51 AM on January 16, 2015: member

@jonasschnelli Right - let's postpone this until the MacOSX unicode issues are fixed.

jonasschnelli commented at 12:21 PM on January 20, 2015: contributor

Prebuilt (gitian) binaries for testing are here: https://bitcoin.jonasschnelli.ch/pulls/5651/

jonasschnelli commented at 3:16 PM on January 20, 2015: contributor

Tested over gitian on OSX and windows.

ACK

laanwj merged this on Jan 20, 2015

laanwj closed this on Jan 20, 2015

laanwj referenced this in commit 848f55d52f on Jan 20, 2015

MarcoFalke locked this on Sep 8, 2021