Implement BIP66 (0.10) #5714

1. 
   sipa commented at 4:19 AM on January 27, 2015: member

   No description provided.

2. laanwj added this to the milestone 0.10.0 on Jan 27, 2015
3. laanwj added the label Priority High on Jan 27, 2015
4. laanwj added the label Validation on Jan 27, 2015
5. 
   luke-jr commented at 2:16 PM on January 30, 2015: member

   utACK: read over non-test commits, looks reasonable.

6. in src/test/script_tests.cpp:None in 5090cd612f outdated

     39 | @@ -40,7 +40,7 @@ using namespace json_spirit;
     40 |  using namespace boost::algorithm;
     41 |  
     42 |  // Uncomment if you want to output updated JSON tests.
     43 | -// #define UPDATE_JSON_TESTS
     44 | +#define UPDATE_JSON_TESTS
   

   ---

   ---

   

   harding commented at 2:29 PM on January 30, 2015:

   Is this supposed to stay uncommented in the actual commit, or is it supposed to be re-commented once the updated JSON has been created?

   ---

   

   luke-jr commented at 2:49 PM on January 30, 2015:

   FWIW, I also noticed this but since I didn't see the generated files in the git repository, I concluded it sense.

   ---

   

   sipa commented at 3:07 PM on January 30, 2015:

   Woops, that uncommenting of the JSON test regeneration is unintentional. On Jan 30, 2015 10:49 AM, "Luke-Jr" notifications@github.com wrote:

   In src/test/script_tests.cpp #5714 (review):

   @@ -40,7 +40,7 @@ using namespace json_spirit; using namespace boost::algorithm;

   // Uncomment if you want to output updated JSON tests. -// #define UPDATE_JSON_TESTS +#define UPDATE_JSON_TESTS

   FWIW, I also noticed this but since I didn't see the generated files in the git repository, I concluded it sense.

   Reply to this email directly or view it on GitHub https://github.com/bitcoin/bitcoin/pull/5714/files#r23846306.

7. 
   theuni commented at 5:33 PM on January 30, 2015: member

   The libbitcoinsonsensus header probably needs access access to SCRIPT_VERIFY_DERSIG now as well. Though it's not a network rule yet, I've already found it useful to use the lib to hack up quick DER checks.

8. 
   theuni commented at 5:37 PM on January 30, 2015: member

   ACK, other than the two issues mentioned above.

   As nits, there are also a few places where comments should probably be updated regardless of what changes: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L1508 and https://github.com/bitcoin/bitcoin/blob/master/src/script/standard.h#L34

9. Change IsDERSignature to BIP66 implementation abfbeafe84
10. Example unit tests from BIP66 18695f08ef
11. BIP66 changeover logic 773c30d756
12. Add RPC test for DERSIG BIP switchover logic 6da2028b55
13. Increase coverage of DERSIG edge cases 3916a81a27
14. sipa force-pushed on Feb 1, 2015
15. 
    sipa commented at 10:02 PM on February 1, 2015: member

    Addressed comments and rebased.

16. 
    gavinandresen commented at 11:47 PM on February 1, 2015: contributor

    ACK. Code reviewed, tested by modifying bipdersig.py a couple of ways and making sure it failed when it should and didn't when it shouldn't.

17. 
    jonasschnelli commented at 8:05 AM on February 2, 2015: contributor

    utACK. Did some test script manipulation and checked results. Looks good to me.

18. 
    theuni commented at 2:45 PM on February 2, 2015: member

    Re-ACK with issues now addressed. Thanks.

19. 
    TheBlueMatt commented at 8:34 PM on February 2, 2015: member

    utACK non-test changes.

20. laanwj merged this on Feb 3, 2015
21. laanwj closed this on Feb 3, 2015

    ---

22. laanwj referenced this in commit 336f9fbd30 on Feb 3, 2015
23. DrahtBot locked this on Sep 8, 2021

Contributors

sipaluke-jrhardingtheunigavinandresenjonasschnelliTheBlueMatt

Milestone
0.10.0