[GUI] Move fee dialog minimise button away from "Transaction Fee:" #5801

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:move_fee_minimize changing 1 files +10 −10

fanquake commented at 11:43 AM on February 18, 2015: member

Original placement seems to be causing some confusion among users. Before

After
paveljanik commented at 4:22 PM on February 18, 2015: contributor

Why do you change various width and height?
fanquake commented at 4:56 PM on February 18, 2015: member

As far as I can workout, without those height/width changes the fee dialog box is no longer minimised when opening the Send tab, which would be altering the current behaviour. @jonasschnelli Can you take a look?
laanwj added the label GUI on Feb 19, 2015
laanwj commented at 9:55 AM on February 19, 2015: member

Height and width values should have no impact at all on being minimized (or hidden in Qt language). If they do, I'm afraid something is buggy.
jonasschnelli commented at 2:02 PM on February 19, 2015: contributor

@fanquake i will have a look at this as soon as im back from vacation (around 5th of march).
fanquake force-pushed on Feb 20, 2015
fanquake commented at 5:42 AM on February 20, 2015: member

Updated to remove height/width changes.
laanwj commented at 8:26 AM on February 20, 2015: member
I disagree with adding more text to the button "Minimize"->"Minimize fee dialog".
- At best, the user would think What is the fee dialog?
- Do we want to use the word 'dialog' in user facing messages at all? This is a UI design term not in general use.
This would be the rare case where a simple 'x' icon would be more descriptive than any amount of text.
fanquake commented at 8:29 AM on February 20, 2015: member

I don't mind either way, if an X would be better lets use that. It just needs to be changed from what it is currently.
laanwj commented at 8:31 AM on February 20, 2015: member

I'm fine with just moving the button, just not adding more text to it. The context should be enough to tell what it minimizes.
[GUI] Move fee dialog minimise button away from "Transaction Fee"
Its original placement was causing confusion among some users.
de5403f878
fanquake force-pushed on Feb 21, 2015
fanquake commented at 1:14 AM on February 21, 2015: member

@laanwj Updated
laanwj merged this on Feb 26, 2015
laanwj closed this on Feb 26, 2015
laanwj referenced this in commit 482783b341 on Feb 26, 2015
fanquake deleted the branch on May 12, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels