As mentioned earlier by @luke-jr in #5200 the "Minimize" button can be mistakenly assumed to minimize the fee. Though, the tool tip makes it clear that the button shrinks the dialog, I'd still prefer a non ambiguous label.
[Qt] Clarify: smartfee button name "Minimize" #5973
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:smartfee-gui-label-fix changing 1 files +1 −1-
MarcoFalke commented at 12:24 PM on April 5, 2015: member
-
jonasschnelli commented at 5:14 PM on April 5, 2015: contributor
SGTM. Will check the GUI and the consistency with other screens.
-
-
laanwj commented at 8:06 AM on April 6, 2015: member
Agree on concept. I'd suggest just making it 'Hide'. This saves translators some work, what it hides should be clear from the context.
- laanwj added the label GUI on Apr 6, 2015
-
6c3566443f
[Qt] Clarify: smartfee button name "Minimize"
Make clear this button hides the options instead of minimizing the transaction fee.
-
MarcoFalke commented at 12:12 PM on April 7, 2015: member
Now, it is "Hide" instead of "Hide options". (Squashed the commit)
-
jonasschnelli commented at 5:53 PM on April 7, 2015: contributor
ACK.
OSX Screen:
-
laanwj commented at 6:47 AM on April 8, 2015: member
Looks good now. ACK.
- laanwj merged this on Apr 8, 2015
- laanwj closed this on Apr 8, 2015
- laanwj referenced this in commit 64b263cc61 on Apr 8, 2015
-
fanquake commented at 6:49 AM on April 8, 2015: member
Post merge ACK
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels