compile with libsecp256k1 #5837

pull haraldh wants to merge 1 commits into bitcoin:master from haraldh:ec-ecdsa changing 1 files +3 −3

haraldh commented at 6:12 PM on February 27, 2015: none

Some function names seems to have changed. secp256k1_ecdsa_pubkey_verify -> secp256k1_ec_pubkey_verify secp256k1_ecdsa_pubkey_decompress -> secp256k1_ec_pubkey_decompress secp256k1_ecdsa_pubkey_tweak_add -> secp256k1_ec_pubkey_tweak_add
haraldh commented at 6:15 PM on February 27, 2015: none

$ use_libsecp256k1=1 ./configure --with-secp256k1 CXXFLAGS="-DUSE_SECP256K1 -O2 -g -Isecp256k1/include" --with-gui=no $ make

works for me to test the compile
haraldh commented at 6:17 PM on February 27, 2015: none

See pull #5838 for the testsuite fix for $ make check

compile with libsecp256k1

Some function names seems to have changed.
secp256k1_ecdsa_pubkey_verify     -> secp256k1_ec_pubkey_verify
secp256k1_ecdsa_pubkey_decompress -> secp256k1_ec_pubkey_decompress
secp256k1_ecdsa_pubkey_tweak_add  -> secp256k1_ec_pubkey_tweak_add

b795f49cf2

theuni commented at 9:55 PM on February 27, 2015: member

Thanks for fixing this up!

Unfortunately, it's not actually intended for use quite yet. Upstream libsecp256k1 hasn't yet given the all-clear, so I think the right thing to do here is to actually remove the temptation until they do. See #5839.
laanwj commented at 1:25 PM on March 2, 2015: member

Agree with @theuni. Thanks for doing this but it's not ready yet. Hopefully we can merge this after the BIP66 softfork. Closing in favor of #5839.
laanwj closed this on Mar 2, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

haraldh

theuni

laanwj

Linked (view graph)

#5839 keys: remove libsecp256k1 verification until it's actually supported