keys: remove libsecp256k1 verification until it's actually supported #5839

pull theuni wants to merge 1 commits into bitcoin:master from theuni:remove-libsecp256k1-verification changing 4 files +0 −39

theuni commented at 9:44 PM on February 27, 2015: member

This was added a while ago for testing purposes, but was never intended to be used. Remove it until upstream libsecp256k1 decides that verification is stable/ready.

Because it appears as though it's optional for use, there have been several efforts to clean it up and get it back in working order. See #5837 #5838 #5811 for examples.

Until this is actually intended to be used, remove it to remove the temptation.
gmaxwell commented at 2:01 AM on February 28, 2015: contributor

utACK.
sipa commented at 10:55 AM on March 1, 2015: member

This doesn't remove support from configure.ac, is that intentional?
laanwj commented at 1:21 PM on March 2, 2015: member

utACK. I like to test around with secp256k1, but it's just as easy to patch it back in instead of fixing it up.
laanwj added the label Build system on Mar 2, 2015
theuni force-pushed on Mar 2, 2015
theuni force-pushed on Mar 2, 2015

keys: remove libsecp256k1 verification until it's actually supported

This was added a while ago for testing purposes, but was never intended to be
used. Remove it until upstream libsecp256k1 decides that verification is
stable/ready.

16a58a8644

theuni commented at 5:05 PM on March 2, 2015: member

@sipa Thanks, I didn't realize those bits were still around. Nuked those as well as the ones in Makefile.am.
sipa commented at 12:07 PM on March 3, 2015: member

reutACK
sipa merged this on Mar 3, 2015
sipa closed this on Mar 3, 2015
sipa referenced this in commit 86eb461c5b on Mar 3, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5811 Resolve warnings in consensus lib builds.#5837 compile with libsecp256k1 #5838 src/key.cpp: fix testsuite with libsecp256k1