src/key.cpp: fix testsuite with libsecp256k1 #5838

pull haraldh wants to merge 1 commits into bitcoin:master from haraldh:testsuite changing 1 files +1 −1

haraldh commented at 6:12 PM on February 27, 2015: none

call secp256k1_start() with SECP256K1_START_VERIFY, otherwise, CPubKey::Verify() is called, which calls secp256k1_ecdsa_verify() and aborts on DEBUG_CHECK(secp256k1_ecmult_consts != NULL);

because secp256k1_start() didn't call secp256k1_ecmult_start(), which initializes secp256k1_ecmult_consts.
haraldh commented at 6:16 PM on February 27, 2015: none

$ use_libsecp256k1=1 ./configure --with-secp256k1 CXXFLAGS="-DUSE_SECP256K1 -O2 -g -Isecp256k1/include" --with-gui=no $ make $ make check

works for me to test the compile and run the testsuite. See pull request #5837 for the compile fix.

src/key.cpp: fix testsuite with libsecp256k1

call secp256k1_start() with SECP256K1_START_VERIFY,
otherwise, CPubKey::Verify() is called, which calls
secp256k1_ecdsa_verify() and aborts on
    DEBUG_CHECK(secp256k1_ecmult_consts != NULL);

because secp256k1_start() didn't call secp256k1_ecmult_start(), which
initializes secp256k1_ecmult_consts.

38f166815b

sipa commented at 12:24 PM on March 3, 2015: member

Closing due to #5839.
sipa closed this on Mar 3, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

haraldh

sipa

Linked (view graph)

#5839 keys: remove libsecp256k1 verification until it's actually supported