fixes #5800
[Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX) #5858
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/03/fix_menu_role changing 1 files +1 −0-
jonasschnelli commented at 8:34 AM on March 6, 2015: contributor
-
9bbb880be4
[Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX)
- fixes #5800
-
jonasschnelli commented at 8:39 AM on March 6, 2015: contributor
The QT behavior on mac will place menu action with string matching to "config, options, setup, settings or preferences" to the general application menu (at very left) and remove them from other menu positions (which is somehow weak IMO).
Currently i only added the
QAction::NoRolerole to theshowHelpMessageActionaction. It is might be discussable to add the "NoRole" to every "standard menu action". - laanwj added the label GUI on Mar 6, 2015
-
laanwj commented at 10:16 AM on March 6, 2015: member
utACK
-
fanquake commented at 12:41 PM on March 6, 2015: member
utACK
On Friday, March 6, 2015, Wladimir J. van der Laan notifications@github.com wrote:
utACK
Reply to this email directly or view it on GitHub #5858 (comment).
-
theuni commented at 5:54 PM on March 6, 2015: member
Nice find. It's very weird that QT uses string matching here on purpose.
utAck.
- laanwj merged this on Mar 9, 2015
- laanwj closed this on Mar 9, 2015
- laanwj referenced this in commit 513e025239 on Mar 9, 2015
-
laanwj commented at 9:49 AM on March 9, 2015: member
It's very weird that QT uses string matching here on purpose
Yes. Qt's autodetection of html/plaintext for labels can be annoying, but this is a few magnitudes worse. The moral of the story is to leave as little a possible to defaults. Explicitly setting the role for all actions makes sense (if I remember correctly it also helps accessibility as screen readers and such use the info).
- laanwj referenced this in commit 786cf72c7f on Mar 9, 2015
- reddink referenced this in commit d917dbc0f0 on May 27, 2020
- MarcoFalke locked this on Sep 8, 2021
