Added a workaround for an Ubuntu bug which causes -fstack-protector-all t #586

pull cjdelisle wants to merge 1 commits into bitcoin:master from cjdelisle:hardening-bug-workaround changing 1 files +6 −1

cjdelisle commented at 12:33 AM on October 17, 2011: none

Added a workaround for an Ubuntu bug which causes -fstack-protector-all to be disregarded. this causes some functions not to be protected and leads to a warning: "warning: not protecting function: no buffer at least 8 bytes long" The bug which this is working around: https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/691722
gmaxwell commented at 12:36 AM on October 17, 2011: contributor

This looks completely reasonable to me. On non-broken systems it will be a no-op, so the workaround can remain indefinitely with no cost... and only get dropped when someone gets around to reviewing the hardening settings at some point in the future.

I don't have a broken ubuntu system to try this on, but I can confirm that its harmless on F14's GCC 4.5.1.
Added a workaround for an Ubuntu bug which causes -fstack-protector-all to be disregarded. 1e5f939381
TheBlueMatt commented at 1:46 AM on October 17, 2011: member

ACK
laanwj commented at 7:28 PM on October 17, 2011: member

ACK, makefiles can never have enough hacks and workarounds :-)
alexwaters commented at 6:05 AM on October 20, 2011: contributor

ACK
gavinandresen referenced this in commit d760b5c979 on Oct 24, 2011
gavinandresen merged this on Oct 24, 2011
gavinandresen closed this on Oct 24, 2011
coblee referenced this in commit d783a2f979 on Jul 17, 2012
ptschip referenced this in commit 635c65144c on May 17, 2017
kallewoof referenced this in commit 28ae91d7de on Oct 4, 2019
rajarshimaitra referenced this in commit d29012d12f on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels