[QT] cleanup icons #6505

MarcoFalke commented at 12:28 PM on August 2, 2015: member

Cleanup SVG code
Unify design ("Typicons" seems to have round edges)
Replace wifi icon with something new

MarcoFalke commented at 12:30 PM on August 2, 2015: member

@jonasschnelli Could you check if clock5.png displays correctly?

Edit: Fixed, see commit.

MarcoFalke force-pushed on Aug 2, 2015

jonasschnelli commented at 5:47 PM on August 2, 2015: contributor

Nice! Thanks. Will test and post some screenshots soon.

luke-jr commented at 10:26 PM on August 2, 2015: member

Where did the "something new" network icon come from? What is its license? This needs to be updated in assets-attribution.md, and must be MIT or similar licensing terms.

laanwj added the label GUI on Aug 3, 2015

jonasschnelli commented at 8:59 AM on August 3, 2015: contributor

In general it looks very good. The new net icons (instead of the "wifi" like icon) has a bit thin lines...

Please update the assets-attribution.md. At least add yourself to the list of designers (https://github.com/MarcoFalke/bitcoin/blob/MarcoFalke-2015-icon-cleanup/doc/assets-attribution.md#jonas-schnelli) so it would be clear that you are publishing under the MIT license.

OSX: <img width="948" alt="bildschirmfoto 2015-08-03 um 10 39 56" src="https://cloud.githubusercontent.com/assets/178464/9033929/218763fc-39cc-11e5-8aa6-c4027fbecc81.png"> <img width="948" alt="bildschirmfoto 2015-08-03 um 10 37 27" src="https://cloud.githubusercontent.com/assets/178464/9033932/218b5566-39cc-11e5-9440-56779cec799d.png"> <img width="74" alt="bildschirmfoto 2015-08-03 um 10 40 17" src="https://cloud.githubusercontent.com/assets/178464/9033930/21878b70-39cc-11e5-81c4-370ddabc3861.png"> <img width="66" alt="bildschirmfoto 2015-08-03 um 10 40 13" src="https://cloud.githubusercontent.com/assets/178464/9033931/2188f370-39cc-11e5-8612-8d2f84f3a9ea.png">

LINUX: <img width="51" alt="bildschirmfoto 2015-08-03 um 10 58 08" src="https://cloud.githubusercontent.com/assets/178464/9034259/904d5b78-39ce-11e5-9c96-5cfa7cfbedfe.png"> <img width="31" alt="bildschirmfoto 2015-08-03 um 10 57 59" src="https://cloud.githubusercontent.com/assets/178464/9034260/9084b30c-39ce-11e5-81ca-19dd104ae990.png"> <img width="28" alt="bildschirmfoto 2015-08-03 um 10 57 55" src="https://cloud.githubusercontent.com/assets/178464/9034261/90899a84-39ce-11e5-9bc3-269ec2197643.png"> <img width="427" alt="bildschirmfoto 2015-08-03 um 10 57 33" src="https://cloud.githubusercontent.com/assets/178464/9034262/908c01d4-39ce-11e5-9952-8081dd0b7ff8.png">

Diapolo commented at 2:10 PM on August 3, 2015: none

I'm not a friend of the new connection symbols, that is a NACK on changing it that way.

jonasschnelli commented at 2:16 PM on August 3, 2015: contributor

@Diapolo: could you give us any objective reasons for your dislike? The current icon is mostly used for WiFi connections and therefore i think changing it makes sense. The new icons would more reflect a p2p "signal strength".

MarcoFalke commented at 2:43 PM on August 3, 2015: member

I will try to make the wires thicker and make another commit of the new p2p-connection symbol, so it is easier not to merge it.

Diapolo commented at 3:50 PM on August 3, 2015: none

@jonasschnelli It reminds me of an USB-like symbol, a USB hub or something. Perhaps we should only use a color indicator red, orange, yellow and green (only if incoming connections are allowed).

laanwj commented at 4:50 PM on August 3, 2015: member

I like the new connection icon. Inventive.

NACK on using a color indicator. We've switched to single-color icons, let's stick to it.

[QT] cleanup icons

* Cleanup SVG code
* Unify design ("Typicons" seem to have round edges)
* Fix transparency issue with clock5.png

9142867572

MarcoFalke force-pushed on Aug 4, 2015

[Qt] replace wifi icon with network symbol df9c2ee1c9

MarcoFalke force-pushed on Aug 4, 2015

MarcoFalke commented at 3:07 PM on August 4, 2015: member

I did the split into two commits, so we have:

First commit:

screenshot from 2015-08-04 12-29-13

Second commit (thicker wires):

screenshot from 2015-08-04 16-14-19

jonasschnelli commented at 3:50 PM on August 4, 2015: contributor

Tested ACK. Bins: https://builds.jonasschnelli.ch/pulls/6505/

laanwj commented at 9:54 AM on August 5, 2015: member

Looks great. ACK. schermafdruk van 2015-08-05 11 49 38

laanwj merged this on Aug 7, 2015

laanwj closed this on Aug 7, 2015

laanwj referenced this in commit 100c9d3994 on Aug 7, 2015

fanquake commented at 11:40 AM on August 7, 2015: member

Post merge ACK. I did have some screens to post but will leave it now.

On Friday, August 7, 2015, Wladimir J. van der Laan < notifications@github.com> wrote:

Merged #6505 #6505.

— Reply to this email directly or view it on GitHub #6505#event-376217959.

MarcoFalke deleted the branch on Aug 7, 2015

MarcoFalke locked this on Sep 8, 2021