Include bitcoin-tx binary on Debian/Ubuntu #6600

pull zw wants to merge 3 commits into bitcoin:master from zw:patch-1 changing 2 files +15 −0

zw commented at 5:53 PM on August 29, 2015: contributor

Currently left out of Matt's PPA. Debian's package for unstable already has it.

Include bitcoin-tx binary on Debian/Ubuntu

Currently left out of Matt's PPA. Debian's package for unstable already has it.

05179f7e9d

jonasschnelli commented at 7:04 PM on August 29, 2015: contributor

utACK
luke-jr commented at 8:49 PM on August 29, 2015: member

This should be a separate package.
zw commented at 11:14 PM on August 29, 2015: contributor

@luke-jr I've no strong feelings; I'm sure I've come across both single-binary packages and lump-it-in-with-the-oft-unused-daemon packages in Debian. Seems like a distro decision to me, but consistency over where to find what binary seems a good idea, however it's achieved.

This does highlight the slightly silly situation of Debian's debianisation living with them (neither clearly following git nor pushing stuff like this to git), and the PPA's debianisation living here. Would be nice to change things in just one place.
laanwj commented at 8:42 AM on August 31, 2015: member

No strong feelings on this, although @luke-jr does have a point. bitcoin-tx is an utility that depends on neither the server nor the RPC client.
laanwj added the label Build system on Aug 31, 2015
jgarzik commented at 1:02 PM on August 31, 2015: contributor

ACK
zw commented at 3:23 PM on September 1, 2015: contributor

Filed a bug with Debian's maintainers, making a case for splitting it out like Gentoo does. Let's see what they say.
jgarzik commented at 11:24 PM on September 15, 2015: contributor

For the moment, the pull request is obviously better than not shipping the tool at all.

It is better to merge this, and then update if the new pkg route is chosen.
dcousens commented at 8:29 AM on September 16, 2015: contributor

ACK, merge unless/until a new package is created.

Split bitcoin-tx into its own package

Reverts the change putting it in the bitcoind deb.

5e5e00bf4c

zw commented at 6:36 AM on September 17, 2015: contributor

No reply on the bug but I can't really see Debian folks disagreeing, so the updated version puts bitcoin-tx in its own single-binary package. @TheBlueMatt might want to comment and/or add a changelog entry, if only so that the resulting package version is bumped to 0.11 - there are Ubuntu-specific suffixes in there so I'm not sure I should touch it.

Drop "with minimal dependencies" from description

Five boost libs plus libcrypto are needed; I don't think that quite passes for minimal.

b0beae8b82

TheBlueMatt commented at 1:05 AM on September 19, 2015: member

utACK as it is now. I would prefer you not touch the changelog (I need to push an update that syncs it with the latest version used against the Ubuntu repo first, so unless you want to do that, just leave it).

On September 17, 2015 1:36:20 AM CDT, Zak Wilcox notifications@github.com wrote:

No reply on the bug but I can't really see Debian folks disagreeing, so the updated version puts bitcoin-tx in its own single-binary package. @TheBlueMatt might want to comment and/or add a changelog entry, if only so that the resulting package version is bumped to 0.11 - there are Ubuntu-specific suffixes in there so I'm not sure I should touch it.

Reply to this email directly or view it on GitHub: #6600 (comment)
laanwj merged this on Sep 24, 2015
laanwj closed this on Sep 24, 2015
laanwj referenced this in commit ef4945f221 on Sep 24, 2015
zw deleted the branch on Sep 26, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels