[Qt] Pop debug window in foreground when opened twice #6653

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-GUI-ActivateDebugWindow changing 6 files +17 −8

MarcoFalke commented at 8:54 PM on September 8, 2015: member

Currently the debug window stays in the background when opened a second time. It should pop up in the foreground, instead.

The commit is pretty much a conceptual copy of 5ffaaba and 382e9e2.

in src/qt/bitcoingui.cpp:None in ad3c9450b1 outdated

 346 | @@ -352,6 +347,11 @@ void BitcoinGUI::createActions()
 347 |      connect(optionsAction, SIGNAL(triggered()), this, SLOT(optionsClicked()));
 348 |      connect(toggleHideAction, SIGNAL(triggered()), this, SLOT(toggleHidden()));
 349 |      connect(showHelpMessageAction, SIGNAL(triggered()), this, SLOT(showHelpMessageClicked()));
 350 | +    connect(openRPCConsoleAction, SIGNAL(triggered()), this, SLOT(showDebugWindow()));
 351 | +    // prevents an open debug window from becoming stuck/unusable on client shutdown
 352 | +    connect(quitAction, SIGNAL(triggered()), rpcConsole, SLOT(hide()));
 353 | +
 354 | +

Diapolo commented at 3:05 PM on September 9, 2015:

Nit: Please remove one of the new-lines.

Diapolo commented at 3:06 PM on September 9, 2015: none

Seems to be another try like mine with #6288.
jonasschnelli commented at 8:32 AM on September 10, 2015: contributor

Tested ACK. Binaries: https://builds.jonasschnelli.ch/pulls/6653/
MarcoFalke force-pushed on Sep 11, 2015

MarcoFalke commented at 9:23 AM on September 11, 2015: member

@Diapolo Thanks for the feedback. I have rearranged the commits according to comments. The rename commit is now HEAD, so it can be easily dropped. @jonasschnelli Thanks for the binaries. The binaries are using now outdated a bit because I force pushed ed2c72e in the meantime. You can expect the following from ed2c72e:

Debug window ...	Mac OS [fanquake]	Fedora Linux (GNOME)	Windows 7
... on another virtual desktop:	switch to virtual desktop and show	switch to virtual desktop and show	n.a.
... hidden behind other windows:	raise to foreground	raise to foreground	raise to foreground
... minimized:	show	n.a.	show

fanquake commented at 9:15 AM on September 12, 2015: member

Tested ed2c72e on OS X

On another virtual desktop: switch to virtual desktop and show
Hidden behind other windows: raise to foreground
Minimised: show

[Qt] Raise debug window when requested

* Raise the debug window when hidden behind other windows
* Switch to the debug window when on another virtual desktop
* Show the debug window when minimized

This change is a conceptual copy of 5ffaaba and 382e9e2

0d0a2d6bf9

Rename rpcconsole.ui => debugwindow.ui 4dee609e10
MarcoFalke force-pushed on Sep 23, 2015
MarcoFalke commented at 8:55 AM on September 23, 2015: member

Trivial rebase (3-way merge)
jonasschnelli commented at 11:43 AM on September 23, 2015: contributor

ReACK.
laanwj merged this on Sep 23, 2015
laanwj closed this on Sep 23, 2015
laanwj referenced this in commit e04b2fa9ba on Sep 23, 2015
MarcoFalke deleted the branch on Sep 24, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors