[Trivial] tests-config.sh is superseded by tests_config.py [skip ci] #6762

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:qatest_gitignore changing 1 files +1 −1

paveljanik commented at 6:18 PM on October 5, 2015: contributor

As qa/pull-tester/tests-config.sh.in was moved to qa/pull-tester/tests_config.py.in in #6616, adapt its .gitignore entry to match new name.
tests-config.sh is superseded by tests_config.py a19504b9ab
paveljanik renamed this:
~~tests-config.sh is superseded by tests_config.py [skip ci]~~
[Trivial] tests-config.sh is superseded by tests_config.py [skip ci]
on Oct 5, 2015
laanwj added the label Tests on Oct 5, 2015
laanwj commented at 7:05 PM on October 5, 2015: member

ACK
fanquake commented at 1:50 AM on October 6, 2015: member

ACK

On Tuesday, October 6, 2015, Wladimir J. van der Laan < notifications@github.com> wrote:

ACK

— Reply to this email directly or view it on GitHub #6762 (comment).
laanwj commented at 8:06 AM on October 6, 2015: member

Next time we should try to look for these things in the review, so they don't require lots of additional pulls to fix up.
laanwj merged this on Oct 6, 2015
laanwj closed this on Oct 6, 2015
laanwj referenced this in commit 66a86a3edb on Oct 6, 2015
paveljanik commented at 8:12 AM on October 6, 2015: contributor

Yup. Maybe we should add the result of git status to the travis build logs?
laanwj commented at 11:20 AM on October 6, 2015: member

I think that's a good idea @theuni can we add a 'tree is clean post-build' check to Travis? It may be complicated by the fact that we're building from a make distdir.

theuni commented at 1:49 AM on October 7, 2015: member

It's ugly, but this works locally:

diff --git a/.travis.yml b/.travis.yml
index c878514..68362f1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -70,4 +70,5 @@ script:
     - if [ "$RUN_TESTS" = "true" ]; then make check; fi
     - if [ "$RUN_TESTS" = "true" ]; then qa/pull-tester/rpc-tests.sh; fi
 after_script:
-    - if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then (echo "Upload goes here. Something like: scp -r $BASE_OUTDIR server" || echo "upload failed"); fi
+    - echo "Checking for left-over files..."
+    - (export GIT_WORK_TREE=.; git ls-files "*.gitignore" | git checkout-index -q --stdin && git ls-files --error-unmatch -- `git ls-files --exclude-standard -o`) && echo "OK"

It grabs the missing .gitignore files (they're not distributed), then uses a GIT_WORK_TREE trick to fool git into acting on the distdir.

It's rather kludgy for the travis file, but I can't imagine it's useful enough to break out on its own. Want me to PR it that way?

MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6616 Regression Tests: Migrated rpc-tests.sh to all Python rpc-tests.py