Git should ignore generated binary bench_bitcoin in git status.
[Trivial] Ignore bench_bitcoin binary [skip ci] #6770
pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:bench_gitignore changing 1 files +1 −0-
paveljanik commented at 3:48 PM on October 6, 2015: contributor
-
Ignore bench_bitcoin binary. b2af29b806
- laanwj added the label Build system on Oct 6, 2015
-
laanwj commented at 4:22 PM on October 6, 2015: member
@paveljanik for .gitignore maintainer :-)
utACK
-
fanquake commented at 4:23 PM on October 6, 2015: member
ACK
On Wednesday, October 7, 2015, Wladimir J. van der Laan < notifications@github.com> wrote:
@paveljanik https://github.com/paveljanik for .gitignore maintainer :-)
utACK
— Reply to this email directly or view it on GitHub #6770 (comment).
-
paveljanik commented at 4:27 PM on October 6, 2015: contributor
On 06 Oct 2015, at 18:23, Wladimir J. van der Laan notifications@github.com wrote:
@paveljanik for .gitignore maintainer :-)
I’m sorry again for not finding it on the first check :-(
Pavel Janík
-
ghost commented at 4:12 AM on October 7, 2015: none
Are we not ignoring src/univalue/build-aux/ ?
-
fanquake commented at 4:14 AM on October 7, 2015: member
Yea, that needs to be added, and should really be done in this pull.
On Wednesday, October 7, 2015, 21E14 notifications@github.com wrote:
Are we not ignoring src/univalue/build-aux/ ?
— Reply to this email directly or view it on GitHub #6770 (comment).
-
paveljanik commented at 5:12 AM on October 7, 2015: contributor
src/univalueis a sub-tree now and it should definitely be done there, not in this pull. And it was already done there - see https://github.com/jgarzik/univalue/commit/81cafe3ef3e0d35565c305ade391a9177ec69a5a. -
fanquake commented at 5:20 AM on October 7, 2015: member
Yep your right, forgot that it was in a sub tree.
On Wednesday, October 7, 2015, paveljanik notifications@github.com wrote:
src/univalue is a sub-tree now and it should definitely be done there, not in this pull. And it was already done there - see jgarzik/univalue@81cafe3 https://github.com/jgarzik/univalue/commit/81cafe3ef3e0d35565c305ade391a9177ec69a5a .
— Reply to this email directly or view it on GitHub #6770 (comment).
- laanwj merged this on Oct 9, 2015
- laanwj closed this on Oct 9, 2015
- laanwj referenced this in commit a99b6cb19e on Oct 9, 2015
-
laanwj commented at 8:17 AM on October 9, 2015: member
for next time: you can put the [skip ci] anywhere in the commit message, it does not have to be in the title (which could be considered ugly)
-
paveljanik commented at 8:19 AM on October 9, 2015: contributor
I consider [skip ci] in the commit message ugly myself 8)
-
MarcoFalke commented at 9:16 AM on October 9, 2015: member
Agree with @paveljanik : "travis spam" should not be in the git commit.
Anyway, I think the correct way is to use[ci skip](not[skip ci]). - zkbot referenced this in commit aa225ebb0b on Jan 24, 2020
- zkbot referenced this in commit 74ff73abab on Jan 24, 2020
- furszy referenced this in commit 4ed15cc69d on Jun 8, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels