Do not allow block file pruning during reindex. #6856

1. 
   morcos commented at 7:38 pm on October 19, 2015: member

   It’s not safe to prune during a reindex, as there may be blocks in earlier files that have not yet been processed if they were out of order. Those files could be accidentally deleted.
   Since undo files are regenerated during reindex, this allocation of disk space could cause pruning to be triggered. @laanwj I thought I was just adding a belt and suspenders check here, but turns out it can and will happen. This should be backported to 0.11.

   Also, clarify startup message that an initial pruning of the block store doesn’t happen if reindexing.

2. Do not allow blockfile pruning during reindex.

   Also clarify startup message.

   d3b09f6bac
3. 
   jonasschnelli commented at 8:04 am on October 20, 2015: contributor

   utACK
4. 
   dcousens commented at 9:04 am on October 20, 2015: contributor

   concept ACK
5. laanwj added the label Block storage on Oct 20, 2015
6. 
   sdaftuar commented at 7:12 pm on October 20, 2015: member

   utACK
7. 
   instagibbs commented at 2:51 pm on October 22, 2015: member

   ACK
8. 
   gmaxwell commented at 6:05 pm on October 22, 2015: contributor

   ACK.
9. 
   fanquake commented at 8:34 am on October 23, 2015: member

   ACK
10. 
    laanwj commented at 12:41 pm on October 23, 2015: member

    utACK
11. laanwj merged this on Oct 23, 2015
12. laanwj closed this on Oct 23, 2015

    ---

13. laanwj referenced this in commit c719cefc41 on Oct 23, 2015
14. laanwj referenced this in commit dfe55bdc32 on Oct 23, 2015
15. 
    laanwj commented at 12:42 pm on October 23, 2015: member

    Backported to 0.11 as dfe55bdc32b5333dcce1a7f2c74628f64028d1fe
16. MarcoFalke locked this on Sep 8, 2021

Contributors
morcos jonasschnelli dcousens sdaftuar instagibbs gmaxwell fanquake laanwj

Labels
Block storage