Reject invalid pubkeys when reading ckey items from the wallet. #6906

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:ckey_pubkey_check changing 1 files +6 −1

gmaxwell commented at 6:29 PM on October 29, 2015: contributor

This makes the behavior more consistent with key objects and will reject some corrupted pubkeys (e.g. zero length).

Reject invalid pubkeys when reading ckey items from the wallet.

This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

30d9662bd7

jonasschnelli commented at 6:56 PM on October 29, 2015: contributor

utACK. Makes sense. LoadCryptedKey() will cast it to a CPubKey object anyways. And the serialization of a CPubKey is equal to a vector<unsigned char> (compact size and the bytestream).
dcousens commented at 8:10 PM on October 29, 2015: contributor

utACK
MarcoFalke commented at 10:29 PM on October 29, 2015: member

utACK
instagibbs commented at 6:20 PM on October 30, 2015: member

utACK
laanwj added the label Wallet on Oct 30, 2015
laanwj merged this on Oct 30, 2015
laanwj closed this on Oct 30, 2015
laanwj referenced this in commit 48b5b84ee5 on Oct 30, 2015
luke-jr referenced this in commit 47736a67a4 on Nov 18, 2015
luke-jr referenced this in commit f1c208d153 on Dec 8, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels