Revert MedianTimePast / mempool-only BIP113 #6928

1. 
   gmaxwell commented at 8:15 pm on November 1, 2015: contributor

   As observed by Luke-Jr, BIP113’s behavior would permit some transactions which are currently invalid. E.g. when the current block time is higher than the MedianTimePast and the transaction’s locktime is between the block time and the MTP.

   There appears to be a straight-forward fix of using MAX(blocktime, MTP+offset) but this deserves some consideration before implementation.

2. Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"

   This reverts commit dea8d21fc63e9f442299c97010e4740558f4f037.

   8537ecdfc4
3. Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations"

   This reverts commit 9d55050773d57c0e12005e524f2e54d9e622c6e2.
   
   As noted by Luke-Jr, under some conditions this will accept transactions which are invalid by the network
    rules.  This happens when the current block time is head of the median time past and a transaction's
    locktime is in the middle.
   
   This could be addressed by changing the rule to MAX(this_block_time, MTP+offset) but this solution and
    the particular offset used deserve some consideration.

   40cd32e835
4. 
   sipa commented at 1:19 am on November 2, 2015: member

   ACK
5. 
   laanwj commented at 2:45 am on November 2, 2015: member

   Ugh. utACK
6. laanwj added the label Mempool on Nov 2, 2015
7. 
   fanquake commented at 3:39 am on November 2, 2015: member

   utACK
8. laanwj merged this on Nov 2, 2015
9. laanwj closed this on Nov 2, 2015

   ---

10. laanwj referenced this in commit 8fe30fb4d1 on Nov 2, 2015
11. 
    maaku commented at 6:16 am on November 2, 2015: contributor

    So since the logic to revert in the first place was incorrect, any chance we can revert the reversion?
12. 
    laanwj commented at 6:58 am on November 2, 2015: member

    We should, but I’m still recovering from panic here.
13. DrahtBot locked this on Sep 8, 2021

Contributors
gmaxwell sipa laanwj fanquake maaku

Labels
Mempool