Fix Boost 1.58.0 build for mips arch #6937

pull arowser wants to merge 1 commits into bitcoin:master from arowser:mips-options-fix changing 2 files +27 −0
  1. arowser commented at 1:03 AM on November 4, 2015: contributor

    The Boost 1.58 can't support build for MIPS32 on a x86_64 machine, the error message is" unrecognized command line option '-m32'". The Boost.Build for version 1.58.0 requires a patch for gcc.jam. This patch prevents bjam from adding -m32 and -m64 options to gcc compiler, when compiling for targets that use the mips1 arch.

    Bug discussed here: https://github.com/openwrt/packages/issues/1160

  2. fix mips option 0264a5caf2
  3. laanwj added the label Build system on Nov 4, 2015
  4. laanwj commented at 8:00 AM on November 4, 2015: member

    utACK

  5. laanwj commented at 9:50 AM on November 4, 2015: member

    Though something is clearly going wrong in boost cross-compilation,

    • the host platform should not influence in any way what gets passed to the target compiler
    • according to man gcc, m32/m64 is only supported on "i386 and x86-64" so I think it would make sense to make the condition the other way around instead of a platform blacklist when not to pass it

    Arguably an upstream issue and it does make sense to include a workaround patch temporarily...

  6. laanwj renamed this:
    Fix Boots 1.58.0 build for mips arch
    Fix Boost 1.58.0 build for mips arch
    on Nov 4, 2015
  7. fanquake commented at 1:34 PM on November 5, 2015: member
  8. laanwj commented at 10:10 PM on November 5, 2015: member

    Thanks @fanquake . Seems what they did is:

    -            if $(arch) != arm
    +            if $(arch) = power || $(arch) = sparc || $(arch) = x86
    

    Which is better as it explicitly defines which platforms can use -mXX (didn't know about power and sparc).

    An alternative would be to bump boost to 1.59 (which includes this). Seems to work fine in local testing.

  9. laanwj commented at 12:21 PM on November 9, 2015: member

    @theuni What do you think is best here?

  10. theuni commented at 8:45 PM on November 9, 2015: member

    @laanwj Agree with a bump to 1.59.

  11. laanwj commented at 3:35 PM on November 10, 2015: member

    Closing in favor of #6980

  12. laanwj closed this on Nov 10, 2015

  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 09:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me