[Depends] Bump Boost, miniupnpc, ccache & zeromq #6980

pull fanquake wants to merge 6 commits into bitcoin:master from fanquake:depends-bump-boost changing 6 files +18 −15
  1. fanquake commented at 3:32 PM on November 10, 2015: member

    Boost 1.59.0 Change-log See #6937

    Miniupnpc 1.9.20151026 Includes @laanwj's string handling/overflow fixes. See https://github.com/miniupnp/miniupnp/pull/157 Changes:

    2015/10/26:
      snprintf() overflow check. check overflow in simpleUPnPcommand2()
    2015/10/25:
      fix compilation with old macs
      fix compilation with mingw32 (for Appveyor)
      fix python module for python <= 2.3
    

    ccache 3.2.4 Fixes a regression related to compiling on some Macs

    Fixed build error related to zlib on systems with older make versions (regression in ccache 3.2.3).
    Made conversion-to-bool explicit to avoid build warnings (and potential runtime errors) on legacy systems.
    Improved signal handling: Kill compiler on SIGTERM; wait for compiler to exit before exiting; die appropriately.
    Minor fixes related to Windows support.
    The correct compression level is now used if compression is requested.
    Fixed a bug where cache cleanup could be run too early for caches larger than 64 GiB on 32-bit systems.
    
  2. [depends] Boost 1.59.0 9e940fa4c6
  3. [depends] miniupnpc 1.9.20151026 17ad964c2f
  4. [depends] native ccache 3.2.4 26f8ea5342
  5. laanwj added the label Build system on Nov 10, 2015
  6. laanwj commented at 5:41 PM on November 10, 2015: member

    Interesting - upnpc fails on macosx:

    clang -target x86_64-apple-darwin11 -mmacosx-version-min=10.7 --sysroot /home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.9.sdk -mlinker-version=241.9 -D_DARWIN_C_SOURCE -fPIC -pipe -O2 -I/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/include -Wall -W -Wstrict-prototypes -fno-common -DMINIUPNPC_SET_SOCKET_TIMEOUT -DMINIUPNPC_GET_SRC_ADDR -D_BSD_SOURCE -D_DEFAULT_SOURCE   -c -o minissdpc.o minissdpc.c
    /usr/bin/libtool -static -o libminiupnpc.a miniwget.o minixml.o igd_desc_parse.o minisoap.o miniupnpc.o upnpreplyparse.o upnpcommands.o upnperrors.o connecthostport.o portlistingparse.o receivedata.o upnpdev.o minissdpc.o
    libtool: unrecognized option `-static'
    libtool: Try `libtool --help' for more information.
    make[1]: *** [libminiupnpc.a] Error 1
    make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/miniupnpc/1.9.20151026-02b712d842a'
    make: *** [/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/miniupnpc/1.9.20151026-02b712d842a/./.stamp_built] Error 2
    make: Leaving directory `/home/travis/build/bitcoin/bitcoin/depends
    
  7. theuni commented at 8:26 PM on November 10, 2015: member

    Looks like they switched to using libtool for creating the static lib. "libtool" in this case is osx's library tool, not the gnu libtool it's finding. Thanks Apple!

    This should fix:

    diff --git a/depends/packages/miniupnpc.mk b/depends/packages/miniupnpc.mk
    index 8cda770..3d5a6df 100644
    --- a/depends/packages/miniupnpc.mk
    +++ b/depends/packages/miniupnpc.mk
    @@ -6,7 +6,7 @@ $(package)_sha256_hash=f3cf9a5a31588a917d4d9237e5bc50f84d00c5aa48e27ed50d9b88dfa
    
     define $(package)_set_vars
     $(package)_build_opts=CC="$($(package)_cc)"
    -$(package)_build_opts_darwin=OS=Darwin
    +$(package)_build_opts_darwin=OS=Darwin LIBTOOL="$($(package)_libtool)"
     $(package)_build_opts_mingw32=-f Makefile.mingw
     $(package)_build_env+=CFLAGS="$($(package)_cflags) $($(package)_cppflags)" AR="$($(package)_ar)"
     endef
    
  8. [depends] Fix miniupnpc compilation on osx 10d3c77644
  9. fanquake force-pushed on Nov 11, 2015
  10. fanquake commented at 7:22 AM on November 11, 2015: member

    Added another commit with @theuni's miniupnpc fix. @theuni If we're bumping depends, are there any others we should look at for 0.12.0? The 4.0.x release of zeromq is now retired, with 4.1.3 being the latest. Should we bring our package (4.0.4) up to the latest release of the retired branch (4.0.7)? Or would we leave it and move to 4.1.x in future?

  11. laanwj commented at 9:45 AM on November 11, 2015: member

    @fanquake For libraries like ZMQ, which are still in quick iteration development, static linking is unfortunately kind of suboptimal. I'd say bump it, otherwise by the time 0.12 final is out we're speaking a dead language :)

  12. [depends] zeromq 4.0.7 23a3c47f95
  13. laanwj commented at 12:27 PM on November 16, 2015: member

    @theuni is this ok for merging?

  14. laanwj commented at 11:12 AM on December 3, 2015: member

    @theuni ping?

  15. fanquake renamed this:
    [Depends] Bump Boost, miniupnpc & ccache
    [Depends] Bump Boost, miniupnpc, ccache & zeromq
    on Dec 4, 2015
  16. theuni commented at 4:46 AM on December 4, 2015: member

    ut ACK.

  17. [depends] Latest config.guess & config.sub e0769e1928
  18. fanquake commented at 9:00 AM on December 9, 2015: member

    @laanwj @theuni I've added another commit that updates config.guess and config.sub to their latest revisions. Minor changes to both files.

  19. laanwj merged this on Dec 18, 2015
  20. laanwj closed this on Dec 18, 2015

  21. laanwj referenced this in commit 8ea5ef1d39 on Dec 18, 2015
  22. laanwj referenced this in commit eccd67106d on Dec 18, 2015
  23. fanquake deleted the branch on May 12, 2016
  24. zkbot referenced this in commit 36df5a92f8 on Feb 9, 2017
  25. zkbot referenced this in commit dd8b38316f on Feb 9, 2017
  26. zkbot referenced this in commit 253c610783 on Feb 9, 2017
  27. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me