Update libsecp256k1

sipa commented at 6:00 am on November 11, 2015: member

This just updates the libsecp256k1 subtree to the latest master. It does not switch validation to it.

Merge commit '313e7f5c89d6e72e06efe9255089765b4c5815fe' into HEAD 31f4ba97b7

build: match upstream build change 3b1279fdb2

Update miniupnpc to 1.9.20151008

This version of miniupnpc fixes a buffer overflow in the XML (ugh)
parser during initial network discovery.

http://talosintel.com/reports/TALOS-2015-0035/

The commit fixing the vulnerability is:
https://github.com/miniupnp/miniupnp/commit/79cca974a4c2ab1199786732a67ff6d898051b78

Reported by timothy on IRC.

0cca0248f0

Merge pull request #6789

0cca024 Update miniupnpc to 1.9.20151008 (Wladimir J. van der Laan)

8c7e6138db

[trivial] Remove obsolete share/qt/make_windows_icon.sh 8a320c7956

[trivial] Make optimize-pngs.py also cover share/pixmaps

Also fix:
"Exception: tostring() has been removed. Please call tobytes() instead."

3507992bcf

[doc] trivial: developer-notes.md covers more than just coding standards 60a8b70585

[doc] trivial: fix markdown syntax in qa/rpc-tests/README.md d0321a4cfd

Bump minrelaytxfee default

To bridge the time until a dynamic method for determining this fee is
merged.

This is especially aimed at the stable releases (0.10, 0.11) because
full mempool limiting, as will be in 0.12, is too invasive and risky to
backport.

28e3249e53

Add tests for gettxoutsetinfo, CLevelDBBatch, CLevelDBIterator

Thanks @dexX7.

1488506872

Refer to obfuscate_key via pointer in peripheral CLevelDB classes

cc @sipa

dcd8e27c65

net: Disable upnp by default

Common sentiment is that the miniupnpc codebase likely contains further
vulnerabilities.

I'd prefer to get rid of the dependency completely, but a compromise for
now is to at least disable it by default.

21d27ebad5

Update debian/changelog and slight tweak to debian/control e253e83c5c

Change URLs to https in debian/control c7b36ccf4a

Merge pull request #6795

21d27eb net: Disable upnp by default (Wladimir J. van der Laan)

b94ae81576

Clarification of unit test build instructions. 700f52e0f6

tests: update transaction_tests for new dust threshold 4e2efb3c5f

[depends] Latest config.guess and config.sub e76d9e4c15

Merge pull request #6793

4e2efb3 tests: update transaction_tests for new dust threshold (Wladimir J. van der Laan)
28e3249 Bump minrelaytxfee default (Wladimir J. van der Laan)

4ca6ddec4d

Create btcdrak-key.pgp 2c4ffbc76e

Updated Prab's PGP Key

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

This message is to inform you that I, Paul Rabahy have rolled over GPG
keys.

My old key = EA695E0CE2D0DCB0D65167A8D1CBA2A21BCD88F6
My new key = D62A803E27E7F43486035ADBBCD04D8E9CCCAC2A

My new key now has an offline primary key with an online subkey that I
will be
using for normal communications.

I have signed this message with both the old and new key so it should show
up
as validly signed. Please add my new key to your keyring so that future
communication will be properly verified.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWB3/LAAoJENHLoqIbzYj2LBwQAMgH5u2KDuxK2gmpRjEpVXe8
XPOon+SRL5zXfu1dFInXCg8APJEVaXhSeY+/s0GmUq0INRpK4r0tvZVN84X2UoHz
y88P6BeHzQI7dsCStINhW4Hb7DVpFvkHAxsRhy05/geD56/IOXnsG+5SvsH3essJ
O6DuRQOipDWkZ9NQuQPrqzlkcBErMbL4Cs0ED5DOOYccntnt5HM909KDHfKcG8iJ
/qNTVzVFYMGbLn6MVq89reatmIOxuVBkbixsqad5M4P9rQ3iGPnUzIEp4wn7/Ssd
XDiCZypzlHkcs1GKBLtWnYWahlWHItcd/Yz3AiHLfUehcZb52p0mvIaTf4lyAR5p
kQFTXZwrrzJDaomSE2Y2IeMIATZE7/7RInkHD6okUTFSoCFgxOeAxLBI6sxLH5x5
xLIdv45iiv3P5fz1gungfzn2OYy+dHgT74bJ32N18hs+xwZM2G6AYYvVvkTSDqC0
c3AopnjEV4i+4Aq0QfDD9fXpBc0QuDN7c5GkcFCiFlhN+gffjT8hkFliiW3e2X5K
Vsycv1sYXFSS/YYZ7RCixWgTkpi18ABaLu/N1ses7hLNMxx9ovjrMIJ5gC6Nyga9
2BiumvNMh0iE9yhPiN0a4YsZZnW/tc5K1+OJxnKZvxWrXqOgIhnKZA1U1Y83COgA
6pI5uKrggGQWgQFJxTmciQEcBAEBCAAGBQJWB3/LAAoJEDJeXsBcJ6amLBwH/ib+
wiD3wDy+VeTDFvh4AgQqDRCk+CvGEKJlcoBLm3ZDwzi+/26XB/BCFoopW9h67ZmC
yMFhgvCJ3RwPcVGgZBOZ//88E2symcYRBSZJVwMN/n3McmEKBmmEH6/tTqhLeBal
2pynse7qgfZV7P/rSMcqFdhzMYq6Jt25obTl3IqTo939G1oOxRK8ORNT3Hs4/uiF
7xsx+nUBe/L6dvw2Rxr8bWm7WKi/LF7fKN/HZuBfK2qH0S4ctG49fiBw3DTV+erO
lYHdOMA9sjk90Le5sNBw75Hyr4WMLUkGFkh9SvDK1Xe3bUCfCpBTpcPnRUqnHL32
9GbqORFiaUGPRCnaWKQ=
=JR4m
-----END PGP SIGNATURE-----

3b363dfe88

zmq: point API link to 4.0 as that is what we are conforming to [Trivial]

Signed-off-by: Johnathan Corgan <johnathan@corganlabs.com>

7d325b9de7

Update bluematt-key, the old one is long-since revoked 3a4a458fe5

Reverse the sort on the mempool's feerate index 78b82f4a16

Add Mempool Expire function to remove old transactions

(note the 9x multiplier on (void*)'s for CTxMemPool::DynamicMemoryUsage
 was accidentally introduced in 5add7a7 but should have waited for this
 commit which adds the extra index)

49b6fd5663

Fix calling mempool directly, instead of pool, in ATMP 9c9b66f771

Track (and define) ::minRelayTxFee in CTxMemPool e8bcdce8a2

Merge pull request #6805

2c4ffbc Create btcdrak-key.pgp (BtcDrak)

1fc5ca05ca

Add CFeeRate += operator 241d6078ba

Merge pull request #6807

3b363df Updated Prab's PGP Key -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 (Paul Rabahy)

cd57f344a5

Print mempool size in KB when adding txn e6c7b362ab

Implement on-the-fly mempool size limitation.

After each transaction which is added to mempool, we first call
Expire() to remove old transactions, then throwing away the
lowest-feerate transactions.

After throwing away transactions by feerate, we set the minimum
relay fee to the maximum fee transaction-and-dependant-set we
removed, plus the default minimum relay fee.

After the next block is received, the minimum relay fee is allowed
to decrease exponentially. Its halflife defaults to 12 hours, but
is decreased to 6 hours if the mempool is smaller than half its
maximum size, and 3 hours if the mempool is smaller than a quarter
its maximum size.

The minimum -maxmempool size is 40*-limitdescendantsize, as it is
easy for an attacker to play games with the cheapest
-limitdescendantsize transactions. -maxmempool defaults to 300MB.

This disables high-priority transaction relay when the min relay
fee adjustment is >0 (ie when the mempool is full). When the relay
fee adjustment drops below the default minimum relay fee / 2 it is
set to 0 (re-enabling priority-based free relay).

794a8cec5d

Only call TrimToSize once per reorg/blocks disconnect d355cf4420

Add reasonable test case for mempool trimming 074cb155c2

Drop minRelayTxFee to 1000

There is no exact science to setting this parameter, but 5000
(just over 1 US cent at the time of writing) is higher than the
cost to relay a transaction around the network (the new benchmark
due to mempool limiting).

9e93640be6

Merge pull request #6788

3b1279f build: match upstream build change (Cory Fields)
313e7f5 Squashed 'src/univalue/' changes from 87d9045..5839ac3 (MarcoFalke)

97bee37d4c

Merge pull request #6812

3a4a458 Update bluematt-key, the old one is long-since revoked (Matt Corallo)

feea3057df

Merge pull request #6798

700f52e Clarification of unit test build instructions. (Eric Lombrozo)

01f74999e3

Merge pull request #6791

d0321a4 [doc] trivial: fix markdown syntax in qa/rpc-tests/README.md (MarcoFalke)
60a8b70 [doc] trivial: developer-notes.md covers more than just coding standards (MarcoFalke)
3507992 [trivial] Make optimize-pngs.py also cover share/pixmaps (MarcoFalke)
8a320c7 [trivial] Remove obsolete share/qt/make_windows_icon.sh (MarcoFalke)

16faccb736

Merge pull request #6777

dcd8e27 Refer to obfuscate_key via pointer in peripheral CLevelDB classes (James O'Beirne)
1488506 Add tests for gettxoutsetinfo, CLevelDBBatch, CLevelDBIterator (James O'Beirne)
0fdf8c8 Handle obfuscation in CLevelDBIterator (James O'Beirne)
3499ce1 Encapsulate CLevelDB iterators cleanly (Pieter Wuille)

9caaf6ed22

Merge pull request #6810

7d325b9 zmq: point API link to 4.0 as that is what we are conforming to [Trivial] (Johnathan Corgan)

a1d623da3e

build: univalue subdir build fixups

- Force a rebuild if the headers change
- Only build the lib target
- Clean univalue on 'make clean'

60af755e56

trivial: use constants for db keys

Replace literal occurances of the key "prefixes" 'c' and 'b' in txdb.cpp
by the respective constants.

f8f2aceadd

[doc] Cleanup release-process documentation a0d5e0d2f4

doc: add comment explaining initial header request

Add a comment that explains why the initial "getheader" requests are
made starting from the block preceding the currently best one.

Thanks to sdaftuar for the explanation!

53b86d0de5

Undo GetMinFee-requires-extra-call-to-hit-0 8abe0f5658

Fix comment formatting tabs 2bc50187ee

Add historical release notes for October 2015 bugfix releases

[skip ci]

d57586f91c

Merge pull request #6830

d57586f Add historical release notes for October 2015 bugfix releases (Micha)

34f200d140

Merge pull request #6823

f8f2ace trivial: use constants for db keys (Daniel Kraft)

fa6b405f05

Merge pull request #6817

a0d5e0d [doc] Cleanup release-process documentation (Michael)

8ce9920635

Merge pull request #6820

60af755 build: univalue subdir build fixups (Cory Fields)

d78a880900

script: Remove magic numbers

This adds two new constants, MAX_OPS_PER_SCRIPT and
MAX_PUBKEYS_PER_MULTISIG.

b48da5c189

[devtools] add clang-format.py 338f62f701

[trivial] Update contrib/devtools/README.md 8c15f33d15

temporarily comment out rpcbind.py

until libevent is fixed. also remove duplicate commented-out forknotify.py.

0658d0ba82

Make fee aware of min relay in pruning.py RPC test b6d5e32e0e

Correct spelling mistakes in doc folder

- OSX —> OS X
- XCode —> Xcode
- github —> GitHub
- homebrew —> Homebrew
- gitian —> Gitian
- Other miscellaneous obvious spelling fixes and whitespace removal

99963b938f

Add DERSIG transaction test cases

Add test cases for DERSIG flag enforcement against transactions.

c6824f8a90

Mention PHP bindings to libbitcoinconsensus d2e3fbc620

Merge pull request #6849

d2e3fbc Mention PHP bindings to libbitcoinconsensus (Thomas Kerin)

5888046323

Fix stale comment in CTxMemPool::TrimToSize. 58254aa3bc

Merge pull request #6843

99963b9 Correct spelling mistakes in doc folder (Mitchell Cash)

fc41278e96

build: make sure OpenSSL heeds noexecstack

This passes `-Wa,--noexecstack` to the assembler when building
platform-specific assembly files, to signal that a non-executable stack
can be used. This is the same approach as used by Debian
(see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430583)

bfcdc21a5d

Merge pull request #6837

0658d0b temporarily comment out rpcbind.py (Alex Morcos)

5f5ee0f3ce

Merge pull request #6852

bfcdc21 build: make sure OpenSSL heeds noexecstack (Wladimir J. van der Laan)

da7d57fb95

Added fPowNoRetargeting field to Consensus::Params that disables nBits recalculation. 7801f4387d

Do not allow blockfile pruning during reindex.

Also clarify startup message.

d3b09f6bac

[rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase 0d8b1759d2

[rpc-tests] Check return code bd4c22ed56

Merge pull request #6829

53b86d0 doc: add comment explaining initial header request (Daniel Kraft)

488f8517a1

Merge pull request #6853

7801f43 Added fPowNoRetargeting field to Consensus::Params that disables nBits recalculation. (Eric Lombrozo)

c834f56869

Merge pull request #6827

bd4c22e [rpc-tests] Check return code (MarcoFalke)
0d8b175 [rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase (MarcoFalke)

87e5539e9c

Merge pull request #6801

e76d9e4 [depends] Latest config.guess and config.sub (fanquake)

ae69a75c55

Merge pull request #6841

b6d5e32 Make fee aware of min relay in pruning.py RPC test (Alex Morcos)

020c4073a0

Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir) f3525e24e3

Chainparams: Translations: DRY: options and error strings

Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine

55a89751fa

http: Restrict maximum size of request line + headers

Prevent memory exhaustion by sending lots of data.
Also add a test to `httpbasics.py`.

Closes #6425

41db8c4733

Merge pull request #6235

55a8975 Chainparams: Translations: DRY: options and error strings (Jorge Timón)
f3525e2 Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir) (Jorge Timón)

e26a3f6713

Merge pull request #6796

c7b36cc Change URLs to https in debian/control (Matt Corallo)
e253e83 Update debian/changelog and slight tweak to debian/control (Matt Corallo)

c6de5cc886

Support -checkmempool=N, which runs checks on average once every N transactions ab1f56072a

Merge pull request #6722

58254aa Fix stale comment in CTxMemPool::TrimToSize. (Matt Corallo)
2bc5018 Fix comment formatting tabs (Matt Corallo)
8abe0f5 Undo GetMinFee-requires-extra-call-to-hit-0 (Matt Corallo)
9e93640 Drop minRelayTxFee to 1000 (Matt Corallo)
074cb15 Add reasonable test case for mempool trimming (Matt Corallo)
d355cf4 Only call TrimToSize once per reorg/blocks disconnect (Matt Corallo)
794a8ce Implement on-the-fly mempool size limitation. (Matt Corallo)
e6c7b36 Print mempool size in KB when adding txn (Matt Corallo)
241d607 Add CFeeRate += operator (Matt Corallo)
e8bcdce Track (and define) ::minRelayTxFee in CTxMemPool (Matt Corallo)
9c9b66f Fix calling mempool directly, instead of pool, in ATMP (Matt Corallo)
49b6fd5 Add Mempool Expire function to remove old transactions (Pieter Wuille)
78b82f4 Reverse the sort on the mempool's feerate index (Suhas Daftuar)

3b20e239c6

Merge pull request #6859

41db8c4 http: Restrict maximum size of request line + headers (Wladimir J. van der Laan)

0fbfc5106c

*: alias -h for --help 3cb56f3778

devtools: Add security-check.py

Perform the following ELF security checks:

- PIE: Check for position independent executable (PIE), allowing for address space randomization
- NX: Check that no sections are writable and executable (including the stack)
- RELRO: Check for read-only relocations, binding at startup
- Canary: Check for use of stack canary

Also add a check to symbol-check.py that checks that only the subset of
allowed libraries is imported (to avoid incompatibilities).

579b863cd7

Merge pull request #6854

579b863 devtools: Add security-check.py (Wladimir J. van der Laan)

a09297010e

[trivial] Rewrite help text for feature enabled by default

c.f #6748

95f4291185

Merge pull request #6846

3cb56f3 *: alias -h for --help (Daniel Cousens)

2cd020d054

Merge pull request #6848

c6824f8 Add DERSIG transaction test cases (J Ross Nicoll)

f2c869aef2

Set TCP_NODELAY on P2P sockets.

Nagle appears to be a significant contributor to latency now that the static
 sleeps are gone.  Most of our messages are relatively large compared to
 IP + TCP so I do not expect this to create enormous overhead.

This may also reduce traffic burstyness somewhat.

a4e28b3d1e

leveldbwrapper: Remove unused .Prev(), .SeekToLast() methods

Also, trim trailing whitespace.

6ec4b7eb20

leveldbwrapper symbol rename: Remove "Level" from class, etc. names 8587b23038

leveldbwrapper file rename to dbwrapper.* 3795e8152b

Fix pre-push-hook regexes 27252b7389

[trivial] rpcnet: fix typo bf681918d7

[trivial] Latest config.guess

upstream commit 1e80063123b47b97d25dfeded8dd92a19dafab66

6782f58368

Merge pull request #6867

a4e28b3 Set TCP_NODELAY on P2P sockets. (Gregory Maxwell)

b2b173acab

Merge pull request #6790

8c15f33 [trivial] Update contrib/devtools/README.md (MarcoFalke)
338f62f [devtools] add clang-format.py (MarcoFalke)

fa1d252e82

Whitelist commits signed with Pieter's now-revoked key 1d94b72019

Merge pull request #6818

b48da5c script: Remove magic numbers (David Hill)

923c5e93a9

Merge pull request #5936

212bcca Add optional locktime to createrawtransaction (Tom Harding)

bf7c1958d1

Merge pull request #6351

65ef372 Add BIP65 to getblockchaininfo softforks list (Peter Todd)
cde7ab2 Add RPC tests for the CHECKLOCKTIMEVERIFY (BIP65) soft-fork (Peter Todd)
287f54f Add CHECKLOCKTIMEVERIFY (BIP65) soft-fork logic (Peter Todd)

2a1090d4f5

doc: Add developer notes about gitignore

- Add developer notes about `.gitignore.`
- Remove qt creator specific files from gitignore, to be consistent.

dca7bd3152

Merge pull request #6856

d3b09f6 Do not allow blockfile pruning during reindex. (Alex Morcos)

c719cefc41

Merge pull request #6873 46f74379b8

Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations

The lock-time code currently uses CBlock::nTime as the cutoff point for time based locked transactions. This has the unfortunate outcome of creating a perverse incentive for miners to lie about the time of a block in order to collect more fees by including transactions that by wall clock determination have not yet matured. By using CBlockIndex::GetMedianTimePast from the prior block instead, the self-interested miner no longer gains from generating blocks with fraudulent timestamps. Users can compensate for this change by simply adding an hour (3600 seconds) to their time-based lock times.

If enforced, this would be a soft-fork change. This commit only adds the functionality on an unexecuted code path, without changing the behaviour of Bitcoin Core.

9d55050773

Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints

Transactions are not allowed in the memory pool or selected for inclusion in a block until their lock times exceed chainActive.Tip()->GetMedianTimePast(). However blocks including transactions which are only mature under the old rules are still accepted; this is *not* the soft-fork required to actually rely on the new constraint in production.

dea8d21fc6

Ignore coverage data related and temporary test files 4d2a926cb4

Remove coverage and test related files, when cleaning up

Until now there were quite a few leftovers, and only the coverage
related files in `src/` were cleaned, while the ones in the other dirs
remained. `qa/tmp/` is related to the BitcoinJ tests, and `cache/` is
related to RPC tests.

d425877557

Require Python for RPC tests, when using lcov

Because Python is (going to be) used to run the RPC tests, when
gathering coverage data with lcov, it is explicitly checked, whether
Python is really available.

8e3a27bbbf

Add config option to enable extended RPC tests for code coverage

When using lcov to gather code coverage data, the configuration option
`--enable-extended-rpc-tests` may be used to enable extended RPC tests.

45d4ff0c20

Run extended BitcoinJ tests for coverage based on config

The configuration option `--enable-comparison-tool-reorg-tests` may be
used to enable extended tests via BitcoinJ also for coverage testing.

e3b5e6c39c

Support gathering of code coverage data for RPC tests

The RPC tests (via `qa/pull-tester/rpc-tests.py`) are now executed,
when gathering code coverage data, for example with `make cov`.

Generating coverage data requires `lcov`, which can installed with:

    sudo apt-get install lcov

To also use the BitcoinJ tests, get the test tool:

    TOOL_URL=https://github.com/theuni/bitcoind-comparisontool/raw/master/pull-tests-8c6666f.jar
    TOOL_HASH=a865332b3827abcde684ab79f5f43c083b0b6a4c97ff5508c79f29fee24f11cd
    wget $TOOL_URL -O ./share/BitcoindComparisonTool.jar
    echo "$TOOL_HASH  ./share/BitcoindComparisonTool.jar" | shasum --algorithm 256 --check

The coverage data can be generated with:

    ./autogen.sh
    ./configure --enable-lcov --with-comparison-tool=./share/BitcoindComparisonTool.jar
    make
    make cov

Optionally the options `--enable-extended-rpc-tests` and
`--enable-comparison-tool-reorg-tests` may be used to enable more time
consuming tests.

It then runs the tests and generates two HTML reports:

 - test_bitcoin.coverage/index.html
 - total.coverage/index.html

d80e3cbece

Add BIP65 CHECKLOCKTIMEVERIFY to release notes c939792baa

added OS X documentation to doc/init.md e04b0b6b83

Use BOOST_CHECK_MESSAGE() rather than BOOST_CHECK() in alerts_tests.cpp and initialize strMiscWarning before calling PartitionCheck()." 143d173969

doc: mention BIP65 softfork in bips.md ceb2a9c3e1

Merge pull request #6879

ceb2a9c doc: mention BIP65 softfork in bips.md (Wladimir J. van der Laan)

450893769f

Merge pull request #6878

dca7bd3 doc: Add developer notes about gitignore (Wladimir J. van der Laan)

867d6c90b8

Merge pull request #6813

d80e3cb Support gathering of code coverage data for RPC tests (dexX7)
e3b5e6c Run extended BitcoinJ tests for coverage based on config (dexX7)
45d4ff0 Add config option to enable extended RPC tests for code coverage (dexX7)
8e3a27b Require Python for RPC tests, when using lcov (dexX7)
d425877 Remove coverage and test related files, when cleaning up (dexX7)
4d2a926 Ignore coverage data related and temporary test files (dexX7)

5242bb32c7

rpc: Add maxmempool and effective min fee to getmempoolinfo 10e2eae35c

Merge pull request #6877

10e2eae rpc: Add maxmempool and effective min fee to getmempoolinfo (Wladimir J. van der Laan)

26f5b34e88

Merge pull request #6566

dea8d21 Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints (Mark Friedenbach)
9d55050 Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations (Mark Friedenbach)

ff057f41aa

fix locking issue with new mempool limiting

Current master crashes on OSX with an exception: "boost: mutex lock failed in pthread_mutex_lock: Invalid argument"

0d699fc821

Introduce -maxuploadtarget

* -maxuploadtarget can be set in MiB
* if <limit> - ( time-left-in-24h-cycle / 600 * MAX_BLOCK_SIZE ) has reach, stop serve blocks older than one week and filtered blocks
* no action if limit has reached, no guarantee that the target will not be  surpassed
* add outbound limit informations to rpc getnettotals

872fee3fcc

Add RPC test for -maxuploadtarget 17a073ae06

Merge pull request #6888

143d173 Use BOOST_CHECK_MESSAGE() rather than BOOST_CHECK() in alerts_tests.cpp and initialize strMiscWarning before calling PartitionCheck()." (Eric Lombrozo)

c8322ff7f7

Merge pull request #6621

e04b0b6 added OS X documentation to doc/init.md (Kevin Cooper)
d4aa54c added org.bitcoin.bitcoind.plist for launchd (OS X) (Kevin Cooper)

dbc5ee821e

Merge pull request #6622

17a073a Add RPC test for -maxuploadtarget (Suhas Daftuar)
872fee3 Introduce -maxuploadtarget (Jonas Schnelli)

7939164d89

Add option for microsecond precision in debug.log 7bbc7c314f

Merge pull request #6881

7bbc7c3 Add option for microsecond precision in debug.log (Suhas Daftuar)

2b625510d3

Merge pull request #6889

0d699fc fix locking issue with new mempool limiting (Jonas Schnelli)

38369dda32

Merge pull request #6464

2d8c49d Clean up tx prioritization when conflict mined (Casey Rodarmor)

8f3b3cdee4

constify missing catch cases

- ensure all missing catch cases are constant where possible

ad5aae15b4

[Trivial] ensure minimal header conventions

- ensure header namespaces and end comments are correct
- add missing header end comments
- ensure minimal formatting (add newlines etc.)

214de7e54c

unittest: fix test for null tx input

Update the unittest that is meant to catch a transaction that is invalid
because it has a null input.  The old test failed not because of that
but because it was considered a coinbase with too large script.  This is
already checked with a different test, though.

The new test is *not* a coinbase since it has two inputs, but one of
them is null.  This really checks the corresponding code path in
CheckTransaction.

0be387a536

Fix BIP65 p2p test

create_coinbase() was being called with the wrong arguments

3e187f2acd

Fix chainstate serialized_size computation 298e040bca

Add Pieter's new PGP key to verify-commits/trusted-keys 6e800c2b41

Update to my new key 4252cd09fd

Merge pull request #6865

298e040 Fix chainstate serialized_size computation (Pieter Wuille)

d0badb916e

Merge pull request #6875

6e800c2 Add Pieter's new PGP key to verify-commits/trusted-keys (Matt Corallo)
1d94b72 Whitelist commits signed with Pieter's now-revoked key (Matt Corallo)
27252b7 Fix pre-push-hook regexes (Matt Corallo)

93521a4f56

Merge pull request #6895

4252cd0 Update to my new key (Pieter Wuille)

8756c98642

Merge pull request #6776

ab1f560 Support -checkmempool=N, which runs checks on average once every N transactions (Pieter Wuille)

e06c14fb59

Merge pull request #6892

214de7e [Trivial] ensure minimal header conventions (Philip Kaufmann)

4764f5db9d

Merge pull request #6891

ad5aae1 constify missing catch cases (Philip Kaufmann)

8daffe227b

Make -checkmempool=1 not fail through int32 overflow e9e616323b

Lower default policy limits

Reduce the default limits on maximum number of transactions and the cumulative size of those transactions in both ancestor and descendant packages to 25 txs and 101kb total size.

971a4e6b86

[wallet] Refactor to use new MIN_CHANGE

* Introduce new constant MIN_CHANGE and use it instead of the
hardcoded "CENT"
* Add test case for MIN_CHANGE
* Introduce new constant for -mintxfee default:
  DEFAULT_TRANSACTION_MINFEE = 1000

6b0e622c25

[wallet] Add comments for doxygen a9c73a130e

Init: Cleanup error and warning strings

Also update doc/translation_strings_policy.md

040c0ea093

Add explicit shared_ptr constructor due to C++11 error a83f3c2426

Merge pull request #6894

3e187f2 Fix BIP65 p2p test (Suhas Daftuar)

26752767df

Merge pull request #6870

040c0ea Init: Cleanup error and warning strings (MarcoFalke)
6782f58 [trivial] Latest config.guess (MarcoFalke)
bf68191 [trivial] rpcnet: fix typo (MarcoFalke)
95f4291 [trivial] Rewrite help text for feature enabled by default (MarcoFalke)

b2ce2c1f0f

Merge pull request #6899

a83f3c2 Add explicit shared_ptr constructor due to C++11 error (Bob McElrath)

b28c229324

Merge pull request #6863

0be387a unittest: fix test for null tx input (Daniel Kraft)

725539ea03

Init: Use DEFAULT_TRANSACTION_MINFEE in help message 6342a4889b

[qt] Use fixed pitch font for the rpc console

Also:
* Preserve white space
* Make fixed font as large as default font

28313b83fc

Reject invalid pubkeys when reading ckey items from the wallet.

This makes the behavior more consistent with key objects and will
 reject some corrupted pubkeys (e.g. zero length).

30d9662bd7

Bugfix: Omit wallet-related options from -help when wallet is disabled a6efc01908

Globals: Explicit Consensus::Params arg for main:

-CheckBlockIndex
-DisconnectTip
-GetTransaction
-InvalidateBlock
-ProcessGetData
-ReadBlockFromDisk

87cbdb8b41

Merge pull request #6896

e9e6163 Make -checkmempool=1 not fail through int32 overflow (Pieter Wuille)

d482c0a7b2

Merge pull request #6906

30d9662 Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)

48b5b84ee5

Make sigcache faster and more efficient 830e3f3d02

Evict sigcache entries that are seen in a block 0b9e9dca4e

Merge pull request #6883

c939792 Add BIP65 CHECKLOCKTIMEVERIFY to release notes (Peter Todd)

a6e80e4017

tests: Initialize networking on windows 7497e805bd

qt: translation update prior to opening 0.12 translations

Also update transifex slug for new version.

02a95be977

Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"

This reverts commit dea8d21fc63e9f442299c97010e4740558f4f037.

8537ecdfc4

Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations"

This reverts commit 9d55050773d57c0e12005e524f2e54d9e622c6e2.

As noted by Luke-Jr, under some conditions this will accept transactions which are invalid by the network
 rules.  This happens when the current block time is head of the median time past and a transaction's
 locktime is in the middle.

This could be addressed by changing the rule to MAX(this_block_time, MTP+offset) but this solution and
 the particular offset used deserve some consideration.

40cd32e835

Don't wipe the sigcache in TestBlockValidity 69d373ff66

build: don't distribute tests_config.py

This file is dynamically generated by configure based on the platform,
it doesn't belong in the distribution archive.

Fixes #6929.

ff2a2af64c

Merge pull request #6926

7497e80 tests: Initialize networking on windows (Wladimir J. van der Laan)

a6d0d623fc

Merge pull request #6928

40cd32e Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations" (Gregory Maxwell)
8537ecd Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints" (Gregory Maxwell)

8fe30fb4d1

Skip BIP30 check after BIP34 activation 06d81ad516

Make skipping BIP30 check chain agnostic 33c90cf197

[qt] Properly display required fee instead of minTxFee abd8b768ee

Clarify what minrelaytxfee does 53238ff0b1

Merge pull request #6930

ff2a2af build: don't distribute tests_config.py (Wladimir J. van der Laan)

42f339ef78

[qt] rpcconsole: Scale monospace font to 95% 268b79ef0c

Restore MedianTimePast for locktime.

Revert "Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations""
This reverts commit 40cd32e835092c3158175511da5193193ec54939.

After careful analysis it was determined that the change was, in fact, safe and several people were suffering
momentary confusion about locktime semantics.

e4e5334ef8

Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints""

This reverts commit 8537ecdfc40181249ec37556015a99cfae4b21fd.

d1c3762ae8

Fix ZMQ Notification initialization and shutdown

Moves the call Initialize() from init.cpp to CreateWithArguments() and handles the
return value. Moves the call Shutdown() from init.cpp to destructor.
Changes Initialize() and Shutdown() to protected members.

de0499d3b8

Merge pull request #6905

a6efc01 Bugfix: Omit wallet-related options from -help when wallet is disabled (Luke Dashjr)
5f9260f Bugfix: If genproclimit is omitted to RPC setgenerate, don't change it; also show correct default in getmininginfo (Luke Dashjr)
420a82f Bugfix: Describe dblogsize option correctly (it refers to the wallet database, not memory pool) (Luke Dashjr)
caa3d42 Bugfix: RPC: blockchain: Display correct defaults in help for verifychain method (Luke Dashjr)

aca0c00ae1

build: Improve build instructions

- Add package instructions for Ubuntu 15.10
- Clarify BerkeleyDB/wallet situation for unix
- Add basic build instructions for Windows (closes #1401)

35bb381435

Merge pull request #6933

35bb381 build: Improve build instructions (Wladimir J. van der Laan)

29c3c43e19

Merge pull request #6927

de0499d Fix ZMQ Notification initialization and shutdown (João Barbosa)

aa03fb35c4

Merge pull request #6669

6342a48 Init: Use DEFAULT_TRANSACTION_MINFEE in help message (MarcoFalke)
a9c73a1 [wallet] Add comments for doxygen (MarcoFalke)
6b0e622 [wallet] Refactor to use new MIN_CHANGE (MarcoFalke)

8a95a18562

devtools: Update README.md 0af8fe45ae

Merge pull request #6864

268b79e [qt] rpcconsole: Scale monospace font to 95% (MarcoFalke)
28313b8 [qt] Use fixed pitch font for the rpc console (MarcoFalke)

c702521a85

BIP70: Chainparams: DRY: Make qt/guiutil.cpp fit BIP70 chain name strings

As a side effect, the qt user will see "test" instead of "testnet"

c53d48a6b3

build: If both Qt4 and Qt5 are installed, use Qt5

If both Qt4 and Qt5 development headers are installed, use Qt5. Building
against Qt5 should be encouraged as that is where active development
happens.

dbacc69b4f

Merge pull request #6938

dbacc69 build: If both Qt4 and Qt5 are installed, use Qt5 (Wladimir J. van der Laan)

193f7b553e

Improving labels for Sent / Received "Bytes"

The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (B, KB, MB) appear after the number.  I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former:
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received

Demo of changes:

Current UI:
    Bytes Sent      12 KB
    Bytes Received  26 MB

With this pull request:
    Sent       12 KB
    Received   26 MB

7ca73dcf6b

Squashed 'src/leveldb/' changes from 7d41e6f..20ca81f

20ca81f Merge pull request #9
7aa105e leveldb: Win32WritableFile without memory mapping

git-subtree-dir: src/leveldb
git-subtree-split: 20ca81f08fb7fa108923a091668e447dcf5c6b9d

fb9857bfd6

Update LevelDB f0343e9370

Always flush block and undo when switching to new file

Previously, the undo weren't being flushed during a reindex because
fKnown was set to true in FindBlockPos. That is the correct behaviour
for block files as they aren't being touched, but undo files are
touched.

This changes the behaviour to always flush when switching to a new file
(even for block files, though that isn't really necessary).

22e780737d

Merge pull request #6944

fb9857b Squashed 'src/leveldb/' changes from 7d41e6f..20ca81f (Pieter Wuille)

79456524f8

Merge pull request #6887

53238ff Clarify what minrelaytxfee does (MarcoFalke)
abd8b76 [qt] Properly display required fee instead of minTxFee (MarcoFalke)

3694b74fa9

Merge pull request #6934

d1c3762 Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"" (Gregory Maxwell)
e4e5334 Restore MedianTimePast for locktime. (Gregory Maxwell)

3038eb63e8

Merge pull request #6948

22e7807 Always flush block and undo when switching to new file (Pieter Wuille)

849a7e6453

[trivial] clang-format: Set AlignAfterOpenBracket: false e0eeb672f2

[doc] Remove excessive white space e167af2acd

Merge pull request #6955

e167af2 [doc] Remove excessive white space (MarcoFalke)
e0eeb67 [trivial] clang-format: Set AlignAfterOpenBracket: false (MarcoFalke)
0af8fe4 devtools: Update README.md (MarcoFalke)

4ee149a6db

Use Pieter's signing subkey instead of his primary key

This commit is signed.

9ea7762e2c

Benchmark sanity checks and fork checks in ConnectBlock 77f1f59d12

doc: there is no libboost-base-dev, add missing sudo

- There is no libboost-base-dev, no idea how I ended up with this
    - Without that, installing separate boost packages works fine on both
      Ubuntu 14.04 and Debian 7 (tested on VMs), this did not use to be
      the case, AFAIK.
- Add a missing 'sudo' for consistency
- Need `bsdmainutils` for `hexdump` (for the tests)

7085728786

Fix crash in validateaddress with -disablewallet

Fix a null pointer dereference in validateaddress with -disablewallet. Also add a regression testcase.

2980a18572

translations: Don't translate markdown or force English grammar 6dd3a44ce2

Merge pull request #6970

2980a18 Fix crash in validateaddress with -disablewallet (Wladimir J. van der Laan)

92701b3b89

Merge pull request #6962

6dd3a44 translations: Don't translate markdown or force English grammar (MarcoFalke)

6176e9bf3d

Merge pull request #6908

c53d48a BIP70: Chainparams: DRY: Make qt/guiutil.cpp fit BIP70 chain name strings (Jorge Timón)

f24880b132

Always allow getheaders from whitelisted peers

Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes #6971.

40b77d450d

Merge pull request #6967

9ea7762 Use Pieter's signing subkey instead of his primary key (Matt Corallo)

503ff6e1ae

transaction_tests: Be more strict checking dust

* Don't allow off-by-one or more
* Make clear dust is coupled with minRelayTxFee
* Check rounding for odd values

5f46a7d068

[trivial] New DEFAULT_MIN_RELAY_TX_FEE = 1000 536766c903

[trivial] init: Use defaults MIN_RELAY_TX_FEE & TRANSACTION_MAXFEE e20d9245e5

build: Split hardening/fPIE options out

This allows for fPIE to be used selectively.

17c4d9d164

build: Use fPIC rather than fPIE for qt objects.

But only if qt was built with reduced relocations.

69d0513436

Merge pull request #6163

87cbdb8 Globals: Explicit Consensus::Params arg for main: (Jorge Timón)

77beab70de

Merge pull request #5574

fd55571 wallet: Expose GUI labels in RPC (Luke Dashjr)

755b4ba848

Merge pull request #6822

e20d924 [trivial] init: Use defaults MIN_RELAY_TX_FEE & TRANSACTION_MAXFEE (MarcoFalke)
536766c [trivial] New DEFAULT_MIN_RELAY_TX_FEE = 1000 (MarcoFalke)
5f46a7d transaction_tests: Be more strict checking dust (MarcoFalke)

9fa54a1b0c

Merge pull request #6940

7ca73dc Improving labels for Sent / Received "Bytes" (Jonathan Cross)

32d8b1570c

qt: Periodic translations update b56953e9bb

net: Automatically create hidden service, listen on Tor

Starting with Tor version 0.2.7.1 it is possible, through Tor's control socket
API, to create and destroy 'ephemeral' hidden services programmatically.
https://stem.torproject.org/api/control.html#stem.control.Controller.create_ephemeral_hidden_service

This means that if Tor is running (and proper authorization is available),
bitcoin automatically creates a hidden service to listen on, without user
manual configuration. This will positively affect the number of available
.onion nodes.

- When the node is started, connect to Tor through control socket
- Send `ADD_ONION` command
- First time:
    - Make it create a hidden service key
    - Save the key in the data directory for later usage
- Make it redirect port 8333 to the local port 8333 (or whatever port we're listening on).
- Keep control socket connection open for as long node is running. The hidden service will
  (by default) automatically go away when the connection is closed.

8f4e67f152

Better error message if Tor version too old 2f796e5fe7

Merge pull request #6965

77f1f59 Benchmark sanity checks and fork checks in ConnectBlock (Matt Corallo)

de7d4591a7

Globals: Make AcceptBlockHeader static (Fix #6163)

..and at the same time prevent AcceptBlockHeader() from calling global function Params()

7267843745

fanquake commented at 7:12 am on November 11, 2015: member

utACK

0bash-3.2$ contrib/devtools/git-subtree-check.sh src/secp256k1
1src/secp256k1 in HEAD was last updated to upstream commit 2bfb82b10edf0f0b0e366a12f94c8b21a914159d (tree 7a74d5de4d518bc5165feeeb75edb0ac4e8c5bea)
2src/secp256k1 in HEAD currently refers to tree 7a74d5de4d518bc5165feeeb75edb0ac4e8c5bea
3GOOD

[gitian] Use vm-builder_0.12.4+bzr494 on Debian 779139549d

Merge pull request #6985

7791395 [gitian] Use vm-builder_0.12.4+bzr494 on Debian (Michael)

38a4f267e8

Merge pull request #6982

7267843 Globals: Make AcceptBlockHeader static (Fix #6163) (Jorge Timón)

cb841e7513

Merge pull request #6978

69d0513 build: Use fPIC rather than fPIE for qt objects. (Cory Fields)
17c4d9d build: Split hardening/fPIE options out (Cory Fields)

3ac7060934

laanwj added the label Build system on Nov 11, 2015

[doc] add documentation how to reduce traffic 6a776faff9

[doc] Fix FIXME for libblkmaker in release-notes.md 0817bf7094

[doc] Improve lanaguge in reducetraffic.md 42bae94e34

Merge pull request #6988

0817bf7 [doc] Fix FIXME for libblkmaker in release-notes.md (MarcoFalke)

44d7b561bc

Merge pull request #6987

42bae94 [doc] Improve lanaguge in reducetraffic.md (fanquake)
6a776fa [doc] add documentation how to reduce traffic (Jonas Schnelli)

c9743062a3

Merge pull request #6974

40b77d4 Always allow getheaders from whitelisted peers (Wladimir J. van der Laan)

2f71b07d5e

Merge pull request #6969

7085728 doc: there is no libboost-base-dev, add missing sudo (Wladimir J. van der Laan)

cbf9609c71

Add basic coverage reporting for RPC tests

Thanks to @MarcoFalke @dexX7 @laanwj for review.

b5cbd396ca

gmaxwell commented at 9:10 pm on November 11, 2015: contributor

ACK

gmaxwell added this to the milestone 0.12.0 on Nov 11, 2015

jtimon commented at 11:23 pm on November 11, 2015: contributor

Concept ACK

Merge pull request #6804

b5cbd39 Add basic coverage reporting for RPC tests (James O'Beirne)

5fcc14ee05

Merge pull request #6931

33c90cf Make skipping BIP30 check chain agnostic (Alex Morcos)
06d81ad Skip BIP30 check after BIP34 activation (Alex Morcos)

54e8bfec83

Merge pull request #6918

69d373f Don't wipe the sigcache in TestBlockValidity (Pieter Wuille)
0b9e9dc Evict sigcache entries that are seen in a block (Pieter Wuille)
830e3f3 Make sigcache faster and more efficient (Pieter Wuille)

eb6172a8ca

torcontrol improvements and fixes

- Force AUTHCOOKIE size to be 32 bytes: This provides protection against
  an attack where a process pretends to be Tor and uses the cookie
  authentication method to nab arbitrary files such as the
  wallet
- torcontrol logging
- fix cookie auth
- add HASHEDPASSWORD auth, fix fd leak when fwrite() fails
- better error reporting when cookie file is not ok
- better init/shutdown flow
- stop advertizing service when disconnected from tor control port
- COOKIE->SAFECOOKIE auth

09c1ae1c01

doc: Mention Tor listening in release notes 68ccdc4696

doc: update docs for Tor listening

- add new data directory files for 0.12 to doc/files.md
- mention torcontrol in doc/tor.md

58ef0ffa9e

Merge pull request #6639

58ef0ff doc: update docs for Tor listening (Wladimir J. van der Laan)
68ccdc4 doc: Mention Tor listening in release notes (Wladimir J. van der Laan)
09c1ae1 torcontrol improvements and fixes (Wladimir J. van der Laan)
2f796e5 Better error message if Tor version too old (Peter Todd)
8f4e67f net: Automatically create hidden service, listen on Tor (Wladimir J. van der Laan)

bd629d77ed

Merge #6771 from branch 'lowerLimits' of git://github.com/morcos/bitcoin 38ed190eef

sipa force-pushed on Nov 12, 2015

Update libsecp256k1 9e475d5a4d

Update key.cpp to new secp256k1 API 48edf5746a

sipa force-pushed on Nov 12, 2015

laanwj commented at 1:23 pm on November 13, 2015: member

Concept ACK.

Should we keep this open until the 0.12 feature freeze, so that new changes to secp256k1 can be included up to then, or better to merge as soon as possible?

jtimon commented at 3:01 pm on November 13, 2015: contributor

I would say merge asap, that will make #6954 easier to review.

jgarzik commented at 3:34 pm on November 13, 2015: contributor

ACK - merge ASAP

sipa merged this on Nov 13, 2015

sipa closed this on Nov 13, 2015

sipa referenced this in commit 4f09b77c7f on Nov 13, 2015

laanwj commented at 11:01 am on November 16, 2015: member

if you get “/home/user/bitcoin/src/key.cpp:204: undefined reference to `secp256k1_ecdsa_sign_recoverable’” errors after updating to master including this pull you need to clean your git tree.

dcousens commented at 8:33 pm on November 16, 2015: contributor

@laanwj yeah had the same, figured it was a build error somewhere. ACK cleaning the tree git clean -xdf works a treat.

zkbot referenced this in commit 66fab27c35 on Jun 17, 2017

zkbot referenced this in commit ef24e8e6be on Jun 17, 2017

MarcoFalke locked this on Sep 8, 2021

Update libsecp256k1 #6983