Remove unmaintained example test script_test.py #7029

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:script-test-cleanup changing 2 files +0 −260
  1. sdaftuar commented at 2:57 PM on November 16, 2015: member

    This was just a proof of concept test that I added when working on #5981; however it's not very useful in travis (it needs multiple bitcoind binaries to do anything useful), and it's unbelievably slow, and so it was just serving as a reference for other test writers interested in local tests comparing multiple binaries.

    However lack of use also leads to inadvertent breakage (as pointed out here: #6971 (comment)), so I think it's probably time to remove.

  2. Remove unmaintained example test script_test.py c800c95997
  3. MarcoFalke commented at 3:12 PM on November 16, 2015: member

    lack of use

    But didn't @luke-jr use it in #6971 (comment)?

    serving as a reference

    Is there a "new and better" way to test multiple bins?

  4. sdaftuar commented at 3:26 PM on November 16, 2015: member

    @MarcoFalke The framework for testing multiple binaries is still in place. The methods I used in this pull (especially using invalidateblock/reconsiderblock over and over) should probably be done a better way somehow, but I haven't thought about how I'd do it again if I were going to reimplement.

    As for the meat of this test, it is just implementing the script tests that are performed by the unit tests already anyway (except over the p2p network), so we're not losing any test coverage functionality that I can think of.

  5. luke-jr commented at 3:32 PM on November 16, 2015: member

    The breakage in #6971 (comment) is related to the test framework more than script_test.py AFAICT...

  6. MarcoFalke commented at 3:34 PM on November 16, 2015: member

    ACK, if no one complains.

  7. jonasschnelli commented at 4:44 PM on November 16, 2015: contributor

    ACK.

  8. jonasschnelli added the label Tests on Nov 16, 2015
  9. fanquake commented at 9:37 AM on November 18, 2015: member

    ACK

  10. laanwj commented at 9:35 AM on November 20, 2015: member

    Removing unmaintained and dead code is good practice. Anyone that wants to 'resurrect' the code can always get it from git history.

    Speaking of which - I'd really like to re-enable the rpcbind.py test without the IPv6 part until the a new stable libevent is in common use. With libevent's release schedule it may take years otherwise :-)

  11. petertodd commented at 12:16 AM on November 21, 2015: contributor

    utACK

  12. gmaxwell commented at 10:47 PM on November 22, 2015: contributor

    ACK.

  13. gmaxwell merged this on Nov 22, 2015
  14. gmaxwell closed this on Nov 22, 2015

  15. gmaxwell referenced this in commit 9cdd407ca5 on Nov 22, 2015
  16. zkbot referenced this in commit 025bd44543 on Nov 21, 2020
  17. zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
  18. zkbot referenced this in commit c8896f9907 on Dec 2, 2020
  19. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 12:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me