Allow 10 additional local P2P connections #712

Raise the connection limit by 10 for local P2P connections, preventing P2Pool and testing efforts from being affected by the global connection limit.

I would highly prefer -keepnode=localhost, this just seems like a hack

You mean adding "keepnode" as a new argument?

This pull's approach seemed like a bit of a hack to me too, though defaulting to allowing extra local connections could only help in cases like these and can't hurt. Not limiting local connections at all would look cleaner, but has a slight potential to cause problems. The only possibility I see is it taking an argument, which would remove the magic "10".

As in #454.

Forrest Voight reply@reply.github.com wrote:

You mean adding "keepnode" as a new argument?

This pull's approach seemed like a bit of a hack to me too, though defaulting to allowing extra local connections could only help in cases like these and can't hurt. Not limiting local connections at all would look cleaner, but could cause problems. The only possibility I see is it taking an argument, which would remove the magic "10".

---

Reply to this email directly or view it on GitHub: #712 (comment)

This might cause problems when we fix issue #610 -- I like Matt's suggestion, although I think it should just be:

addnode=local.ip.address.1 addnode=local.ip.address.2 ... etc ...

I agree (and want to watch this pull)

This was a hack, though I'd like to get addnode or keepnode to default to allowing localhost...