Fix osslsigncode patch url #7360

pull achow101 wants to merge 2 commits into bitcoin:master from achow101:doc-fix changing 3 files +3 −3

achow101 commented at 1:55 AM on January 17, 2016: member

Fixed the download url of osslsigncode-Backports-to-1.7.1.patch file to reflect its new location.

Fix osslsigncode patch url

Fixed the download url of osslsigncode-Backports-to-1.7.1.patch file to reflect its new location.

da696c76e3

fanquake commented at 1:56 AM on January 17, 2016: member
ACK

On Sunday, 17 January 2016, Andrew C notifications@github.com wrote:
Fixed the download url of osslsigncode-Backports-to-1.7.1.patch file to

reflect its new location.

You can view, comment on, or merge this pull request online at:

#7360 Commit Summary

Fix osslsigncode patch url

File Changes

M doc/release-process.md https://github.com/bitcoin/bitcoin/pull/7360/files#diff-0 (2)

Patch Links:

#7360.patch

#7360.diff

— Reply to this email directly or view it on GitHub #7360.
jonasschnelli commented at 6:59 PM on January 17, 2016: contributor

ACK. nit: this PR could also include the now wrong SDK URL in the .travis file: https://github.com/bitcoin/bitcoin/blob/master/.travis.yml#L19
jonasschnelli added the label Build system on Jan 17, 2016
MarcoFalke commented at 7:04 PM on January 17, 2016: member

Shouldn't this 302 instead of 404? @btcdrak ?
Point to correct dev.bitcoincore.org url 4feff60d5c
btcdrak commented at 8:21 PM on January 17, 2016: contributor

Change URL to http://

SSL is not required here since all the other downloads are made over http and validated using hashes.
achow101 commented at 8:24 PM on January 17, 2016: member

@btcdrak still 404.

Unless you mean where the travis build failed.
btcdrak commented at 8:37 PM on January 17, 2016: contributor

@achow101 I mean your PR must be changed to http://

Thinking again @cfields should probably move this to /depends-sources folder, I've messaged him on IRC.
btcdrak commented at 9:26 PM on January 17, 2016: contributor

I spoke with @cfields on IRC and he will update the URL to use /depends-sources
laanwj commented at 9:19 AM on January 18, 2016: member

@btcdrak Can't we solve this using a redirect, in the same manner as #7351?

It is very possible for dev.bitcoincore.org to go away in the near future, so I prefer not hardcoding it in any way.
btcdrak commented at 11:51 AM on January 18, 2016: contributor

Redirect is in place.
laanwj commented at 2:19 PM on January 18, 2016: member

Ok, closing this
laanwj closed this on Jan 18, 2016
theuni commented at 3:22 PM on January 18, 2016: member

Thanks for taking care of this.

For future reference, the change has been merged upstream, but it hasn't made it into a release yet: http://sourceforge.net/p/osslsigncode/osslsigncode/ci/3be7eb1676a8af8afd9e0aa03e4cac651da14c23/

Unfortunately, it doesn't look like sf.net provides an easy way to extract a patch.
achow101 deleted the branch on Jan 19, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels