Bump transaction version default to 2 #7562

pull btcdrak wants to merge 4 commits into bitcoin:master from btcdrak:txversionbump changing 22 files +116 −44
  1. btcdrak commented at 5:32 pm on February 19, 2016: contributor

    This should be merged after the BIP68 softfork enforces.

    EDIT: BIP68 has long since activated so miners are running min 0.12.1 and therefore will mine v2 txs. Also there are sufficient nodes on the network relaying v2 txs

  2. btcdrak referenced this in commit 5056de3a47 on Feb 19, 2016
  3. jonasschnelli added the label Consensus on Feb 20, 2016
  4. paveljanik commented at 7:51 am on March 29, 2016: contributor
    After bumping the default tx version to 2, we should also have some test to test v1 transactions.
  5. laanwj commented at 4:27 pm on April 15, 2016: member
    Needs rebase (but probably only after it is eligible for merge in the first place)
  6. laanwj commented at 9:53 am on August 3, 2016: member
    @btcdrak Is there anything still blocking this? (apart from needing rebase)
  7. MarcoFalke commented at 9:02 pm on August 24, 2016: member
    Does this need mention in the release notes?
  8. btcdrak force-pushed on Aug 26, 2016
  9. btcdrak force-pushed on Aug 27, 2016
  10. btcdrak force-pushed on Aug 27, 2016
  11. jonasschnelli added the label TX fees and policy on Aug 29, 2016
  12. jonasschnelli added the label Mempool on Aug 29, 2016
  13. jonasschnelli removed the label Consensus on Aug 29, 2016
  14. paveljanik commented at 4:47 pm on October 8, 2016: contributor

    What is the status of this?

    Needs rebased.

  15. btcdrak force-pushed on Oct 26, 2016
  16. btcdrak force-pushed on Oct 26, 2016
  17. btcdrak force-pushed on Oct 27, 2016
  18. laanwj commented at 8:01 pm on November 2, 2016: member
    @sipa @gmaxwell any opinion here? Can this be merged for 0.14?
  19. gmaxwell commented at 8:55 pm on November 22, 2016: contributor
    utACK. I think this is fine now!
  20. morcos commented at 10:25 pm on December 6, 2016: member

    ugh, thats a lot of work. thanks @btcdrak

    I reviewed everything so far except the changes in test/data

    technically the mempool_tests change was a bug in the test, here’s a fix b095828 if you want it that means you don’t need to add the version.

  21. morcos commented at 10:51 pm on December 6, 2016: member
    OK I’ve gone through test/data for as long as I can stand it. utACK
  22. btcdrak force-pushed on Dec 7, 2016
  23. btcdrak commented at 8:57 pm on December 7, 2016: contributor

    ugh, thats a lot of work. @morcos was a lot more than I bargained for, to change a 1 to a 2 :laughing:

    I’ve added your commit thanks for that as it simplifies things a bit. Squashed.

  24. btcdrak force-pushed on Dec 7, 2016
  25. fanquake commented at 5:18 am on December 8, 2016: member

    Travis failure:

    02016-12-07 22:53:39,532 - ERROR - Output data mismatch for txcreate2.hex (format hex)
12016-12-07 22:53:44,125 - ERROR - Output data mismatch for txcreate2.json (format json)
22016-12-07 22:54:44,785 - ERROR - FAILED TESTCASES: [Parses a transation with no inputs and a single output script, Parses a transation with no inputs and a single output script (output in json)]
  26. btcdrak commented at 10:17 am on December 8, 2016: contributor
    @fanquake I’m stuck, I cant replicate the fails locally. I’m going to experiment and push the PR before rebase and see if it still fails or not.
  27. btcdrak force-pushed on Dec 8, 2016
  28. fanquake commented at 10:58 am on December 8, 2016: member

    I’m able to recreate locally, this is merged on top of master:

    0/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS check-local
1Running test/bitcoin-util-test.py...
22016-12-08 18:40:39,202 - ERROR - Output data mismatch for txcreate2.hex (format hex)
32016-12-08 18:40:39,207 - ERROR - Output data mismatch for txcreate2.json (format json)
42016-12-08 18:40:39,307 - ERROR - FAILED TESTCASES: [Parses a transation with no inputs and a single output script, Parses a transation with no inputs and a single output script (output in json)]
5make[3]: *** [check-local] Error 1
6make[3]: *** Waiting for unfinished jobs....
  29. paveljanik commented at 11:04 am on December 8, 2016: contributor

    I’m not able to replicate locally.

    Sorry, couldn’t resist: some typo collector should grab “transation”.

  30. btcdrak commented at 2:31 pm on December 8, 2016: contributor
    I reverted the addition of b095828 because Travis was playing up. We can do that in a separate PR.
  31. Bump default transaction version to 2 1f0ca1ae1c
  32. tiny test fix for mempool_tests c5d746ace7
  33. Preserve tx version=1 for certain tests 
    Without this change, the tests would be affected by default
tx version increases.
    dab207e4e6
  34. Update python tests for default tx version=2 c5c92c46fb
  35. btcdrak force-pushed on Dec 8, 2016
  36. btcdrak commented at 8:15 pm on December 8, 2016: contributor
    OK after investigation from @morcos and others found something had changed in master, so I had to rebase to master and fix a couple of new tests that had been introduced. Travis should pass now, and I’ve again included @morcos patch.
  37. laanwj merged this on Dec 15, 2016
  38. laanwj closed this on Dec 15, 2016
  39. laanwj referenced this in commit 1eef038b1b on Dec 15, 2016
  40. btcdrak deleted the branch on Dec 15, 2016
  41. droark commented at 3:27 am on December 17, 2016: contributor

    Hello. Going through this PR, I noticed that a couple of files now seem to not be used. Is this intentional? It doesn’t seem so.

    • src/test/data/blanktx.json (Doesn’t seem to be used, although it could presumably be given a v1 rename and used for a v1 test.)
    • src/test/data/txcreatesign.json (Exact copy of txcreatesignv1.json, so it’s redundant.)

    I’m happy to file a PR and fix this. Just want to make sure I’m on the right path first. :) A txcreatesignv2.json test would probably be good too. I can write that.

    Thanks.

  42. btcdrak commented at 10:31 am on December 17, 2016: contributor
    @droark +1
  43. domob1812 referenced this in commit 548b9dd259 on Dec 17, 2016
  44. btcdrak commented at 7:47 am on December 19, 2016: contributor
    @droark I had to knock out a quick PR because the orphan reference was causing someone an issue on IRC, see #9376
  45. unknown referenced this in commit b4df057a0a on Jan 5, 2018
  46. unknown referenced this in commit e8e17cfac2 on Jan 6, 2018
  47. unknown referenced this in commit 5ffcf4f78e on Jan 7, 2018
  48. unknown referenced this in commit bd8de06241 on Jan 8, 2018
  49. unknown referenced this in commit 62cd5c39b1 on Jan 10, 2018
  50. unknown referenced this in commit 89fe1edad0 on Jan 13, 2018
  51. unknown referenced this in commit 11dff8aa43 on Jan 19, 2018
  52. codablock referenced this in commit 0fc37e8c56 on Jan 20, 2018
  53. andvgal referenced this in commit ba4a530d79 on Jan 6, 2019
  54. CryptoCentric referenced this in commit 00f694be87 on Feb 27, 2019
  55. CryptoCentric referenced this in commit 04c6965a9c on Mar 5, 2019
  56. CryptoCentric referenced this in commit 21648e4d62 on Mar 6, 2019
  57. CryptoCentric referenced this in commit 449f4c93e2 on Mar 6, 2019
  58. furszy referenced this in commit 1f010c0969 on Jan 23, 2021
  59. DrahtBot locked this on Sep 8, 2021


btcdrak paveljanik laanwj MarcoFalke gmaxwell morcos fanquake droark

Labels
TX fees and policy Mempool

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me