...nfo"
This reverts commit 340f0876eabcabefa77588585f7c8f29954dcb48.
The data provided by that commit are useless and there is no reason to make the code that much worse by adding yet more globals in a poorly-written way for that info.
Revert "collect more info on tx pooling and block finding for getminingi... #766
pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:fixmininginfo changing 3 files +35 −36-
TheBlueMatt commented at 7:59 PM on January 18, 2012: member
-
164f2d1729
Revert "collect more info on tx pooling and block finding for getmininginfo"
This reverts commit 340f0876eabcabefa77588585f7c8f29954dcb48.
-
luke-jr commented at 8:00 PM on January 18, 2012: member
It's not useless, and not worse. Stop trolling.
[14:59:12] <luke-jr> BlueMatt: I'm not going to waste time arguing over something stupid like this. It's better now than it was before. If you want to improve on it, go ahead. If not, that's no excuse to complain it's imperfect and rip it out.
-
TheBlueMatt commented at 8:01 PM on January 18, 2012: member
My point is that its worthless info, mucks up the code that much more, and should never have been merged. Since its not actually released, there is no harm in removing it.
-
Readd nPooledTx and nLastBlockTx in a reasonable way. af10d0d65f
-
TheBlueMatt commented at 8:19 PM on January 18, 2012: member
Readded nPooledTx and nLastBlockTx in a reasonable way.
-
luke-jr commented at 8:20 PM on January 18, 2012: member
currentblocksize is missing
-
TheBlueMatt commented at 8:37 PM on January 18, 2012: member
I'm not gonna fix all your code for you, I was just showing that your claims that it's impossible to do well without a ton of changes were unfounded.
Luke-Jr reply@reply.github.com wrote:
currentblocksize is missing
Reply to this email directly or view it on GitHub: #766 (comment)
-
TheBlueMatt commented at 7:32 AM on February 18, 2012: member
Superseded by 4b54cb93e87816c50e5da90767ee1bc056166552 in cblockstore.
- TheBlueMatt closed this on Feb 18, 2012
- ptschip referenced this in commit 9ca33878a5 on Dec 27, 2017
- Losangelosgenetics referenced this in commit e713379f6f on Mar 12, 2020
- Losangelosgenetics referenced this in commit af1c556584 on Mar 12, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors