Fix headers announcements edge case #7919

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:fix-sendheaders-edge-case changing 1 files +15 −1

sdaftuar commented at 6:26 PM on April 20, 2016: member

Previously we would assert that if every block in vBlockHashesToAnnounce is in chainActive, then the blocks to be announced must connect. However, there are edge cases where this assumption could be violated (eg using invalidateblock / reconsiderblock), so just check for this case and revert to inv-announcement instead.

FYI I encountered this bug once while running mempool_packages.py, and was able to reproduce reliably by repeatedly invoking invalidateblock/reconsiderblock on the tip.

Perhaps we should backport this to 0.12 as well?

Fix headers announcements edge case

Previously we would assert that if every block in vBlockHashesToAnnounce is in
chainActive, then the blocks to be announced must connect.  However, there are
edge cases where this assumption could be violated (eg using invalidateblock /
reconsiderblock), so just check for this case and revert to inv-announcement
instead.

3a99fb2cb1

morcos commented at 6:42 PM on April 20, 2016: member

utACK
jonasschnelli added the label P2P on Apr 21, 2016
jonasschnelli commented at 7:07 AM on April 21, 2016: contributor

utACK 3a99fb2cb14955f5e029d315041a093e957e6c3e
sipa commented at 8:54 AM on April 21, 2016: member

utACK 3a99fb2
paveljanik commented at 1:45 PM on April 21, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/7919/commits/3a99fb2cb14955f5e029d315041a093e957e6c3e
TheBlueMatt commented at 6:21 AM on April 22, 2016: member
utACK 3a99fb2cb14955f5e029d315041a093e957e6c3e

On April 20, 2016 11:26:28 AM PDT, Suhas Daftuar notifications@github.com wrote:
Previously we would assert that if every block in vBlockHashesToAnnounce is in chainActive, then the blocks to be announced must connect. However, there are edge cases where this assumption could be violated (eg using invalidateblock / reconsiderblock), so just check for this case and revert to inv-announcement instead.

FYI I encountered this bug once while running mempool_packages.py, and was able to reproduce reliably by repeatedly invoking invalidateblock/reconsiderblock on the tip.

Perhaps we should backport this to 0.12 as well? You can view, comment on, or merge this pull request online at:

#7919

-- Commit Summary --

Fix headers announcements edge case

-- File Changes --

M src/main.cpp (16)

-- Patch Links --

#7919.patch #7919.diff

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #7919
laanwj added the label Needs backport on Apr 22, 2016
laanwj merged this on Apr 22, 2016
laanwj closed this on Apr 22, 2016
laanwj referenced this in commit 76176823ba on Apr 22, 2016
MarcoFalke referenced this in commit 20a2bd7abe on Apr 25, 2016
MarcoFalke referenced this in commit 43c14acf14 on Apr 27, 2016
MarcoFalke commented at 10:58 AM on June 9, 2016: member

Backported as part of #7938. Removing label 'Needs backport'.
MarcoFalke removed the label Needs backport on Jun 9, 2016
thokon00 referenced this in commit f4cb7ebdeb on Jun 28, 2016
nomnombtc referenced this in commit e9edf81666 on Nov 12, 2016
nomnombtc referenced this in commit 1e3b7ed3df on Nov 12, 2016
nomnombtc referenced this in commit 8eb18b8bc9 on Nov 13, 2016
sickpig referenced this in commit 4622fcdbed on Nov 14, 2016
MarkLTZ referenced this in commit 3120c258d3 on Apr 27, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels