This also avoids flushing setAddrKnown until 24 hours has passed, and avoids contacting the external IP services when not listening.
Advertising non-listening nodes is just addr message spam. It doesn't help the network, in fact it hurts the network, and it also hurts user's privacy.
Advertising far out of sync nodes doesn't help the network— they can't even forward (most) transactions and wastes nodes outbound slots.
This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.
Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.
Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.
This is a fairly minimal change for sane behavior. I think we also should check that our listening is working before advertising and that we shouldn't advertise when we're completely full, but the first requires a fair amount of additional code and the second requires careful consideration.
ACK
ACK
ACK, sanity tested with/without -nolisten.