Log invalid block hash to make debugging easier. #7952

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160426_Log_invalid_block changing 1 files +1 −1

paveljanik commented at 8:25 PM on April 26, 2016: contributor

Log block hash in AcceptBlockHeader.

Right now, it is a bit hard to sync on plain testnet. This helped debugging.
Log invalid block hash to make debugging easier. 61c01706cd
paveljanik commented at 8:38 PM on April 26, 2016: contributor
FYI: right now, the current master is not able to sync on plain testnet with
```
ERROR: AcceptBlockHeader: block 00000000000005354772cb50ea2decd1e9176724c41eb3427197943aea33194e is marked invalid
```
This is block 787391 (https://www.blocktrail.com/tBTC/block/00000000000005354772cb50ea2decd1e9176724c41eb3427197943aea33194e).
mruddy commented at 9:38 PM on April 26, 2016: contributor

Yep, I noticed that testnet is forked too. Looks like the CSV fork activated and the 0.12.1 clients followed a different chain when block=00000000000005354772cb50ea2decd1e9176724c41eb3427197943aea33194e height=787391 encountered "ERROR: ConnectBlock: contains a non-BIP68-final transaction". The 0.12.1 chain is longer height wise, but has lower work so the older clients reject it right now. That wasn't the case last night. Last night, my client was not sync'ing to the most work chain because it was hitting the "Large reorg, won't direct fetch to ..." case in the headers message processing. That I thought was kind of interesting from the standpoint of what would happen if SPV mining created a bad chain 17 or so blocks long in production. My node seemed stuck at that point, just sitting there not really doing anything.
laanwj commented at 9:17 AM on April 27, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/7952/commits/61c01706cd1d38023facea7f25bc1d84980f8c43
laanwj added the label Docs and Output on Apr 27, 2016

mruddy commented at 1:41 AM on April 28, 2016: contributor

test ACK. before and after (from testnet):

2016-04-28 01:27:26 ERROR: AcceptBlockHeader: block is marked invalid
2016-04-28 01:32:43 ERROR: AcceptBlockHeader: block 00000000000005354772cb50ea2decd1e9176724c41eb3427197943aea33194e is marked invalid

fanquake commented at 6:45 AM on April 28, 2016: member

utACK 61c0170
gmaxwell commented at 6:54 AM on April 28, 2016: contributor

utACK.
MarcoFalke commented at 7:06 AM on April 28, 2016: member

utACK 61c0170
laanwj merged this on Apr 28, 2016
laanwj closed this on Apr 28, 2016
laanwj referenced this in commit a9c8b744e8 on Apr 28, 2016
codablock referenced this in commit f709da81d7 on Sep 16, 2017
codablock referenced this in commit 05e7102ca9 on Sep 19, 2017
codablock referenced this in commit 03507a720c on Dec 20, 2017
MarkLTZ referenced this in commit 3120c258d3 on Apr 27, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels