[Doc] Simplify OS X build notes #8029

fanquake commented at 8:37 AM on May 9, 2016: member

Add --c++11 flag to brew dependancies that support it Remove release-build section, this is covered by depends/release-notes @theuni can I get your thoughts on adding the --c++11 flag to brew dependancies?

Link to the rendered markdown

MarcoFalke added the label Docs and Output on May 9, 2016

in doc/build-osx.md:None in 2bf1bacf25 outdated

  31 | -The installation of the actual dependencies is covered in the instructions
  32 | -sections below.
  33 | +Install [Homebrew](http://brew.sh).
  34 |  
  35 | -Instructions: Homebrew
  36 | +Dependancies

paveljanik commented at 8:12 PM on May 9, 2016:

Dependencies

in doc/build-osx.md:None in 2bf1bacf25 outdated

  43 | +NOTE: Building with Qt4 is still supported, however, could result in a broken UI. Building with Qt5 is recommended.
  44 |  
  45 | -NOTE: Building with Qt4 is still supported, however, could result in a broken UI. As such, building with Qt5 is recommended.
  46 | -
  47 | -### Building `bitcoin`
  48 | +Build bitcoin

paveljanik commented at 8:14 PM on May 9, 2016:

Please change this to Bitcoin Core, not bitcoin.

in doc/build-osx.md:None in 2bf1bacf25 outdated

  49 | +------------------------
  50 |  
  51 | -1. Clone the GitHub tree to get the source code and go into the directory.
  52 | +1. Clone the bitcoin source code and cd into `bitcoin`
  53 |  
  54 |          git clone https://github.com/bitcoin/bitcoin.git

paveljanik commented at 8:14 PM on May 9, 2016:

.git not needed

in doc/build-osx.md:None in 2bf1bacf25 outdated

  70 | +3.  It is recommended to build and run the unit tests:
  71 |  
  72 |          make check
  73 |  
  74 | -4.  (Optional) You can also install bitcoind to your path:
  75 | +4.  Install bitcoind to your path (optional):

paveljanik commented at 8:15 PM on May 9, 2016:

If we are changing this, we should probably not recommend make install and help the reader to build app bundle.

theuni commented at 3:01 PM on May 10, 2016:

agreed. 'make deploy' would likely be more useful to users.

fanquake force-pushed on May 10, 2016

theuni commented at 3:04 PM on May 10, 2016: member

Looks like protobuf supports the c++11 flag as well. edit: whoops, misread. This is already there.

theuni commented at 3:12 PM on May 10, 2016: member

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

If not, we should upstream a patch while we're at it.

theuni commented at 3:21 PM on May 10, 2016: member

ACK adding the c++11 flags and simplifying.

Also, since it's no longer mentioned (hasn't been in a while, I suppose), we should remove the port check from configure.ac

[Doc] Simplify OS X build notes

Add —c++11 flags to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes

2692e1b10b

fanquake force-pushed on May 12, 2016

fanquake commented at 12:50 PM on May 12, 2016: member

Changed step 4 to make deploy @theuni I'll start submitting PRs to Homebrew to update dependancies (and sub dependancies) that we use.

fanquake commented at 2:06 PM on May 12, 2016: member

PRs to update miniupnpc, expat, dbus, ccache

fanquake commented at 8:32 AM on May 14, 2016: member

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here) @theuni Looking at the output of brew install qt5 --verbose --build-from-source, it looks like it is.

   Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3)
   qmake vars: QMAKE_CC = clang QMAKE_CXX = clang++
   Build options:
   Configuration: c++11 c++14 c++1z
   Using C++ standard: c++1z

Assuming their bottles are built the same way.

arowser commented at 8:43 AM on May 25, 2016: contributor

Can one of the admins verify this patch?

jonasschnelli commented at 8:44 AM on June 2, 2016: contributor

ACK 2692e1b10bd7a0be644ed8a69c54152bc741e855

jonasschnelli merged this on Jun 2, 2016

jonasschnelli closed this on Jun 2, 2016

jonasschnelli referenced this in commit 58725ba89d on Jun 2, 2016

fanquake deleted the branch on Jun 12, 2016

codablock referenced this in commit a27f1caa59 on Sep 16, 2017

codablock referenced this in commit 037ca12ab2 on Sep 19, 2017

codablock referenced this in commit dbf4dc4de6 on Dec 22, 2017

andvgal referenced this in commit 4387f4a3e7 on Jan 6, 2019

MarcoFalke locked this on Sep 8, 2021