[OSX] fix make deploy when compiling on OSX #8135

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/06/makedeploy changing 4 files +13 −22

jonasschnelli commented at 7:56 AM on June 2, 2016: contributor

Should fix #8120. There is a ugly issue of a python sub-package incompatibility #8134
jonasschnelli added the label MacOSX on Jun 2, 2016
in configure.ac:None in 4ee30fc505 outdated
```
  67 | @@ -68,6 +68,7 @@ AC_PATH_TOOL(GCOV, gcov)
  68 |  AC_PATH_PROG(LCOV, lcov)
  69 |  AC_PATH_PROG(JAVA, java)
  70 |  AC_PATH_PROGS([PYTHON], [python3 python2.7 python2 python])
  71 | +AC_PATH_PROGS([PYTHON2], [python2.7 python2 python])
```
jonasschnelli commented at 7:56 AM on June 2, 2016:

This is not really elegant. Fixing the upstream pip package would probably the way to go.

laanwj commented at 1:17 PM on June 6, 2016:

If this requires everyone to have Python 2 installed, including those that aren't building on mac, that's not really acceptable

jonasschnelli commented at 1:18 PM on June 6, 2016:

Yes. Totally agree, ... I'm testing now the solution from @theuni (https://github.com/bitcoin/bitcoin/issues/8120#issuecomment-223691744).

theuni commented at 3:54 PM on June 9, 2016:

At this point, I'm thinking the easiest thing to do is just pull mac_alias and ds_store into our repo in macdeploy. They're small/simple enough, and that saves us a ton of complexity.
fanquake commented at 8:24 AM on June 2, 2016: member

This seems to work, but still required some playing around with pip to get the correct packages installed. It didn't seem to find the brew installed python2 packages?

Could you rebase the doc changes off #8029 ? Also, should we just delete the readme in contrib/macdeploy ?
jonasschnelli force-pushed on Jun 2, 2016
[OSX] fix make deploy when compiling on OSX 6414cbe23c
jonasschnelli force-pushed on Jun 2, 2016
jonasschnelli commented at 8:56 AM on June 2, 2016: contributor

Rebased on now merged #8029, simplified contrib/macdeploy's readme,
jonasschnelli commented at 12:35 PM on July 20, 2016: contributor

ping @theuni, does this still make sense? I guess #8120 is still unfixed?
droark commented at 12:17 AM on August 2, 2016: contributor

Ahhh, I just stumbled across this issue today. Glad to see that people are looking into it.

Having looked at the proposed solutions, I think theuni's proposal that ds_store and mac_alias be pulled into the repo is reasonable. They're ~1300 lines of Python code each. Not tiny but quite manageable.
jonasschnelli commented at 7:27 AM on August 26, 2016: contributor

Closing in the hope @theuni will PR https://github.com/theuni/bitcoin/commit/c622254170d4bd8c5ca75077214105cef666f4c4.
jonasschnelli closed this on Aug 26, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8120 [OSX] `make deploy` is currently failing #8134 Native ds_store python package is not python3 compatible