[qa] Cleanup doesn't get top level directory #8647

1. 
   sdaftuar commented at 12:42 AM on September 2, 2016: member

   I think after #8098, the cleanup that happens at the end of an rpc test no longer deletes the temp datadir created by default. (I have a whole bunch of directories in /tmp/ now that I didn't use to have, so I think that's the cause...)

   Would be nice for cleanup to work as it used to, at least in the situation where no datadir is being passed in as an argument.

2. fanquake added the label Tests on Sep 2, 2016
3. 
   rodentrabies commented at 9:22 AM on September 2, 2016: contributor

   This can be fixed either with @sdaftuar's suggestion in #8098 discussion, or by backing up tmpdir to some other variable for removal in case it is empty at that point. Which one is more appropriate?

4. 
   MarcoFalke commented at 12:34 PM on September 4, 2016: member

   Thanks for creating the issue. We also have a cleanup problem where at least one bak file is left after the test passed. (Probably wallet-dump.py, trivial to fix). As well as a problem with not cleaning up the temp folder when creating the cache dirs.

5. MarcoFalke added this to the milestone 0.13.1 on Sep 13, 2016
6. MarcoFalke added the label Needs backport on Sep 13, 2016
7. 
   MarcoFalke commented at 5:47 PM on September 13, 2016: member

   I think the linked pulls should be backported

8. MarcoFalke added the label Priority Low on Sep 15, 2016
9. MarcoFalke closed this on Sep 16, 2016

   ---

10. MarcoFalke removed the label Needs backport on Sep 16, 2016
11. MarcoFalke removed the label Priority Low on Sep 16, 2016
12. DrahtBot locked this on Sep 8, 2021

Milestone
0.13.1