[OSX] `make deploy` is currently failing #8120

issue fanquake opened this issue on May 30, 2016

fanquake commented at 11:47 AM on May 30, 2016: member

OS X 10.11.5, Python 3.5.1 After building as usual.

$ make deploy
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C src qt/bitcoin-qt
/usr/local/bin/python3 ./contrib/macdeploy/macdeployqtplus Bitcoin-Qt.app -add-qt-tr da,de,es,hu,ru,uk,zh_CN,zh_TW -translations-dir= -dmg -fancy ./contrib/macdeploy/fancy.plist -verbose 2 -volname Bitcoin-Core
Error: Could not find background picture at "background.tiff" or "./contrib/macdeploy/background.tiff"
make: *** [Bitcoin-Core.dmg] Error 1

The instructions in macdeploy/README.md might also need updating.

jonasschnelli added the label MacOSX on May 31, 2016
MarcoFalke commented at 1:20 PM on June 1, 2016: member

Have you tried with git clean -dfx (make sure to move any untracked files out of the way) or try in a fresh worktree: https://git-scm.com/docs/git-worktree#_examples
fanquake commented at 2:15 AM on June 2, 2016: member

Yes, same result after running git clean -dxf
luke-jr commented at 3:39 AM on June 2, 2016: member

Do you have rsvg-convert, ImageMagick, and tiffcp? These are required for make deploy now.
fanquake commented at 4:09 AM on June 2, 2016: member
Yes, all installed via brew
```
librsvg
imagemagick
libtiff
```
luke-jr commented at 4:11 AM on June 2, 2016: member

Does configure find them? Post config.log
fanquake commented at 4:22 AM on June 2, 2016: member
Looks like it doesn't
```
IMAGEMAGICK_CONVERT=''
RSVG_CONVERT=''
TIFFCP=''
```
Full config.log
luke-jr commented at 4:26 AM on June 2, 2016: member

Has this ever worked? All the make deploy program checks are only for non-Mac build systems in configure...
jonasschnelli commented at 6:41 AM on June 2, 2016: contributor

There are serval problems with the "make deploy" target on OSX. The Makefile.am's image/background generation only runs when not compiling on OSX (bug). Also the configure.ac scrips only looks for imagemagick & co. if not compiling on OSX (bug). On top of that, configure.ac looks for python3 in the first place which is incompatible with the current make deploy macdeployplus.py script.

Will fix soon.
theuni commented at 7:18 PM on June 3, 2016: member

@jonasschnelli on native osx, the macdeploy script uses the "-fancy" option, which uses native osx tools rather than requiring the same ones needed for cross builds. This was done because at the time, there was no way to generate everything using open tools.

When the svg stuff was added and the static images were removed, the native side wasn't updated.

So here's what I'd propose: Switch to the open tools as much as possible. For everything that requires python2, use the native OSX tools until they're updated. At that point, we can switch away.
theuni commented at 8:53 PM on June 3, 2016: member
Meh, now that I have it done up, I'm not sure that I care for it. Changes here: https://github.com/theuni/bitcoin/commit/c622254170d4bd8c5ca75077214105cef666f4c4 Compared to the approach in #8135:

Pros:
- Doesn't require python2
- Doesn't require imagemagick
Cons
- Uses system utils and doesn't match the way we do releases
laanwj commented at 12:03 PM on June 20, 2016: member

@theuni Whatever we do, we should not make python2 a dependency in the cases where it is not explicitly needed (e.g. native macosx build). That would undo all the work I did to make the build system and tests work without Python 2.
laanwj commented at 7:42 AM on July 30, 2016: member

Is this still the case?
sylvaingeron commented at 8:01 PM on August 23, 2016: none

I got the same message today :"Error: Could not find background picture at "background.tiff" or "./contrib/macdeploy/background.tiff" make: *** [Bitcoin-Core.dmg] Error 1

And when doing "bitcoin-cli getinfo", I get "errors": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications". This might explain that.

jguitton commented at 9:20 AM on August 24, 2016: none

If someone want to do the pull request to close this issue :

diff --git a/contrib/macdeploy/fancy.plist b/contrib/macdeploy/fancy.plist
index ef277a7..a6a1c31 100644
--- a/contrib/macdeploy/fancy.plist
+++ b/contrib/macdeploy/fancy.plist
@@ -10,7 +10,7 @@
                <integer>620</integer>
        </array>
        <key>background_picture</key>
-       <string>background.tiff</string>
+       <string>background.svg</string>
        <key>icon_size</key>
        <integer>96</integer>
        <key>applications_symlink</key>

jonasschnelli commented at 9:26 AM on August 24, 2016: contributor

@jguitton thanks. Yes. Your solution could work,.. I guess macdeploy calls imagemagicks convert (if compiled with SVG support, this should work). I think https://github.com/theuni/bitcoin/commit/c622254170d4bd8c5ca75077214105cef666f4c4 is more stable and should be PRed (ping @theuni ).
jguitton commented at 10:05 AM on August 24, 2016: none

@jonasschnelli i don't see any tiff, png or psd in the repo. @theuni pr is partly about converting png files. now that only the svg file is present, references to tiff or png are not relevant anymore.
jonasschnelli commented at 10:11 AM on August 24, 2016: contributor

Right. You have to convert the SVG anyways. The question is, how the PR should look like that it works on most OSX setups. AFAIK The plus of @theunis PR is, that the required tools are checked during configure-level.
jonasschnelli closed this on Jan 2, 2017
Sjors commented at 6:00 PM on December 12, 2017: member

I just ran make deploy on a fresh OSX machine with running make first (yes, ignoring the instruction). I get the same error as @sgeron and both icons are missing:

<img width="512" alt="schermafbeelding 2017-12-12 om 18 47 15" src="https://user-images.githubusercontent.com/10217/33899804-e3f80930-df6c-11e7-864c-9cf29abc9bf1.png">

Apart from running make, I had to eject /Volumes/Bitcoin Core (which isn't obvious as it's not visible on the desktop).

Anyway, I should just follow instructions :-)
Sjors commented at 6:03 PM on December 12, 2017: member

Actually that didn't work. The preview while running make deploy did show the icons, but the end product doesn't. I'll look a bit more.
Sjors commented at 6:11 PM on December 12, 2017: member

It went away after a reboot, sigh.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8135 [OSX] fix make deploy when compiling on OSX #9412 build: Fix 'make deploy' for OSX #17528 `make deploy` is failing on macOS