[trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog #8207

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1606-LicInfo changing 1 files +10 −1

MarcoFalke commented at 9:13 AM on June 15, 2016: member

Alternative to #8192
MarcoFalke added the label Docs and Output on Jun 15, 2016
btcdrak commented at 9:37 AM on June 15, 2016: contributor

We should also have a link to the project website.
gmaxwell commented at 9:46 AM on June 15, 2016: contributor

Perhaps better to just link the website, in case we move off github in the future?
btcdrak commented at 9:47 AM on June 15, 2016: contributor

@gmaxwell agreed. The website address should be more permanent than the source repository which may or may not change in the future.
MarcoFalke commented at 10:52 AM on June 15, 2016: member

@btcdrak @gmaxwell I still think it is useful to have a link directly to the GitHub repo. I think there are no plans to move away from GitHub in the near future. Though, we may switch to the bitcoin-core organization some time...

Also, I have added two links to the website.
MarcoFalke renamed this:
~~[trivial] Add a link to the Bitcoin-Core repository to the About Dialog~~
[trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog
on Jun 15, 2016
sipa commented at 11:23 AM on June 15, 2016: member

utACK
sipa commented at 11:24 AM on June 15, 2016: member

I think listing both the source code and the project website is a good idea.
in src/init.cpp:None in fa66b76f88 outdated
```
 489 |             "\n" +
 490 | +           strprintf(_("The source code is available from %s."),
 491 | +               URL_SOURCE_CODE) +
 492 | +           "\n" +
 493 | +           "\n" +
 494 | +           strprintf(_("Additional information about %s is available at %s."),
```
paveljanik commented at 11:27 AM on June 15, 2016:

Two %s can make the translation a bit hard in some languages where the order of words in the sentence is a bit different.

MarcoFalke commented at 11:46 AM on June 15, 2016:

:hankey:

MarcoFalke commented at 11:50 AM on June 15, 2016:

Someone should write a macro that uses nested strprinf's, so you can use the number of %'s to indicate the precedence of the format specifier

MarcoFalke commented at 12:12 PM on June 15, 2016:

Thanks, worked around for now.
btcdrak commented at 11:43 AM on June 15, 2016: contributor

fine, but my personal preference would just link to "https://bitcoincore.org" rather than a specific page.
paveljanik commented at 11:46 AM on June 15, 2016: contributor

Yes, just one link please. It would be also nice to not have About windows scrollable because of lot of texts.
MarcoFalke force-pushed on Jun 15, 2016
MarcoFalke commented at 12:13 PM on June 15, 2016: member
btcdrak commented at 1:31 PM on June 15, 2016: contributor

utACK fa6565d
paveljanik commented at 1:48 PM on June 15, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/commit/fa6565d2fc9c4cd8eac57915dc8b0aef8176b39c
paveljanik commented at 1:54 PM on June 15, 2016: contributor

When you are in this file, can you change the http:// to https:// in the MIT link?
MarcoFalke added this to the milestone 0.13.0 on Jun 15, 2016
MarcoFalke commented at 2:05 PM on June 15, 2016: member

@paveljanik Please mention this in #8192 (I can't change already translated strings as part of this pull anymore, as we are freezing translations tomorrow)
paveljanik commented at 3:15 PM on June 15, 2016: contributor

@MarcoFalke ? You have just added the string "Please contribute if you..". So?
MarcoFalke commented at 3:43 PM on June 15, 2016: member
@paveljanik The problem is with already translated strings. Currently we have 161 project languages (27 without translators) and not even the German translations for 0.12 are fully done.

If you change a translated string, people would need to go through the about ~80 languages where it is already translated and apply the difference. This may or may not happen.

To sum up:
- Having no translation is better than having no link to our websites at all.
- Having a slightly outdated translation (e.g. a http link) is better than no translation at all.
paveljanik commented at 3:47 PM on June 15, 2016: contributor

Sure, but in the case of http -> https, we can simply postprocess the transifex files.
jonasschnelli commented at 7:39 AM on June 16, 2016: contributor

Please squash. ACK fa6565d2fc9c4cd8eac57915dc8b0aef8176b39c
[doc] Add website links to about dialog fa58e5ee93
MarcoFalke force-pushed on Jun 16, 2016
MarcoFalke commented at 8:11 AM on June 16, 2016: member

@jonasschnelli: Squashed fa6565d into fa58e5e
laanwj commented at 8:51 AM on June 16, 2016: member

Perhaps better to just link the website, in case we move off github in the future?

In that case we'll just update the software.

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

Unfortunately, no, we can't do that. Postprocessing the ts files is simple, but getting the data back to Transifex without breaking all their metadata is not.

utACK fa58e5e, this seems the best solution for 0.13 as we don't want to break translation strings.
laanwj merged this on Jun 16, 2016
laanwj closed this on Jun 16, 2016
laanwj referenced this in commit f7a403b4cf on Jun 16, 2016
MarcoFalke deleted the branch on Jun 16, 2016
codablock referenced this in commit ae89861caf on Sep 16, 2017
codablock referenced this in commit 30330b18a7 on Sep 19, 2017
codablock referenced this in commit 6e69b46b83 on Dec 27, 2017
codablock referenced this in commit 9875ab5353 on Dec 28, 2017
andvgal referenced this in commit 1bac5ff494 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021