[WIP][depends] ZeroMQ 4.1.5 && ZMQ on Windows #8238

1. 
   fanquake commented at 10:18 am on June 22, 2016: member

   This is an attempt to revive the work started by @theuni in #6819, and hopefully close issues #7943 and #6681.

   Even if we still can’t fix the Windows linking issues, it might be worth moving to the newer ZeroMQ version. Release notes as follows:

    00MQ version 4.1.5 stable, released on 2016/06/17
    1================================================
    2* Fixed 1673 - CMake on Windows put PDB in wrong directory.
    3* Fixed 1723 - Family is not set when resolving NIC on Android.
    4* Fixed 1608 - Windows 7 TCP slow start issue.
    5* Fixed 1806 - uninitialised read in curve getsockopt.
    6* Fixed 1807 - build broken with GCC 6.
    7* Fixed 1831 - potential assertion failure with latest libsodium.
    8* Fixed 1850 - detection issues with tweetnacl/libsodium.
    9* Fixed 1877 - Avoid terminating connections prematurely
   10* Fixed 1887 - zmq_bind IPv4 fallback still tries IPv6
   11* Fixed 1866 - fails to build on SunOS 5.10 / Solaris 10
   12* Fixed 919 - ZMQ_LINGER (related to [#1877](/bitcoin-bitcoin/1877/))
   13* Fixed 114 - cannot unbind with same endpoint with IPv6 enabled.
   14* Fixed 1952 - CMake scripts not part of release tarballs
   15* Fixed 1542 - Fix a crash on Windows when port 5905 is in use.
   16* Fixed 2021 - Fix building on sparc32.
   

   The changes to enable static linking in ZeroMQ have been made in #1615 and then a follow up in #1978 / #1979.

   We no longer need the headergaurd patch from #6819, as those changes seem to be in src/windows.hpp. Introduced in #901.

   Hopefully pulling all this info together means we can get this working.

2. fanquake force-pushed on Jun 22, 2016
3. MarcoFalke added the label Build system on Jun 22, 2016
4. fanquake force-pushed on Jun 22, 2016
5. fanquake force-pushed on Jun 22, 2016
6. fanquake force-pushed on Jun 22, 2016
7. fanquake force-pushed on Jun 22, 2016
8. fanquake force-pushed on Jun 22, 2016
9. 
   jonasschnelli commented at 7:16 pm on June 22, 2016: contributor

   Nice. Started a gitian build: https://bitcoin.jonasschnelli.ch/pulls/8238/
10. 
    jonasschnelli commented at 6:39 pm on June 23, 2016: contributor

    Compiled successfully on all three platforms: https://bitcoin.jonasschnelli.ch/pulls/8238/
11. 
    fanquake commented at 7:04 am on June 24, 2016: member

    @achow101 Given you opened #7943, are you able to download one of @jonasschnelli’s test binaries and try using ZMQ ?
12. 
    achow101 commented at 2:44 pm on June 24, 2016: member

    @fanquake looks like it works on windows now.
13. 
    sipa commented at 2:49 pm on June 24, 2016: member

    Concept ACK
14. laanwj assigned theuni on Jun 27, 2016
15. 
    theuni commented at 5:03 am on June 28, 2016: member

    Concept ACK. I’d prefer going a slightly different route, though.

    Upstream removed the mingw requirement here: https://github.com/zeromq/libzmq/commit/9114d3957725acd34aa8b8d011585812f3369411 and a fixup here: https://github.com/zeromq/libzmq/commit/9e6745c12e0b100cd38acecc16ce7db02905e27c .

    I’d prefer to take those patches directly. Then we can simply drop the patches when we update to a release that includes them.

16. 
    theuni commented at 4:03 pm on July 6, 2016: member

    @fanquake Please have a look at https://github.com/theuni/bitcoin/commit/a8d5faacf5b193cb3468df24ab568f59dab282bb . That takes the upstream commits, as well as disabling curve, which was necessary for me locally.
17. fanquake force-pushed on Jul 8, 2016
18. 
    fanquake commented at 1:49 am on July 8, 2016: member

    Updated with @theuni’s suggestions
19. 
    fanquake commented at 9:06 am on July 13, 2016: member

    Can someone on Windows @achow101, retest this?
20. 
    achow101 commented at 2:51 pm on July 13, 2016: member

    ACK 6a08416c5c1955a2ccec9bf393d829e1a4c34892
21. [depends] ZeroMQ 4.1.5 a615386552
22. fanquake force-pushed on Jul 21, 2016
23. laanwj merged this on Jul 30, 2016
24. laanwj closed this on Jul 30, 2016

    ---

25. laanwj referenced this in commit 6caf3ee061 on Jul 30, 2016
26. fanquake deleted the branch on Aug 1, 2016
27. zkbot referenced this in commit 36df5a92f8 on Feb 9, 2017
28. zkbot referenced this in commit dd8b38316f on Feb 9, 2017
29. zkbot referenced this in commit 253c610783 on Feb 9, 2017
30. codablock referenced this in commit 161939a5c3 on Sep 19, 2017
31. codablock referenced this in commit d50a2aeb02 on Dec 29, 2017
32. codablock referenced this in commit eb54680c35 on Jan 8, 2018
33. DrahtBot locked this on Sep 8, 2021

Contributors
fanquake jonasschnelli achow101 sipa theuni

Labels
Build system