These changes should also be backported to the stable releases so that they build and test on systems which don't install python to /usr
It also changes python scripts which are not related to tests because it was easier not to have grep discriminate.
0 | @@ -1,4 +1,4 @@ 1 | -#!/usr/bin/python2 2 | +#!/usr/bin/env python2
Couldn't this say #!/usr/bin/env python, since #7723?
Yes, security-check works with python 3 too. The build system calls all these scripts by passing them to the python interpreter, so it doesn't care what is on the first line.
I made no attempt to check for portability of the python scripts between python releases, just a straight s/// on all *.py files
Can you remove the trailing 2's according to the pull request I linked above?
There are 5 files using python2, only security-check.py and symbol-check.py (notably not test-security-check.py) have been changed in #7723. Accordingly I've changed only the same two files.
contrib/devtools/security-check.py:#!/usr/bin/env python2 contrib/devtools/symbol-check.py:#!/usr/bin/env python2 contrib/devtools/test-security-check.py:#!/usr/bin/env python2 contrib/zmq/zmq_sub.py:#!/usr/bin/env python2 share/rpcuser/rpcuser.py:#!/usr/bin/env python2
I'm happy to abandon this PR in favour of incorporating the changes directly in #7723 if it simplifies things.
0 | @@ -1,4 +1,4 @@ 1 | -#!/usr/bin/python2
Did we actually test that this works on python3?
@petertodd See @laanwj's comment #8270 (review)
utACK 7b01ce254cfa0e8ae7e57a72c57e8ae89f3c1829
utACK 7b01ce2
utACK 7b01ce2