Inline CTxInWitness inside CTxIn #8589

1. 
   sipa commented at 11:31 am on August 25, 2016: member

   This is a rebase of #8452 on top of #8580.
2. jonasschnelli added the label Refactoring on Aug 29, 2016
3. sipa force-pushed on Sep 5, 2016
4. sipa force-pushed on Sep 19, 2016
5. sipa force-pushed on Oct 2, 2016
6. 
   fanquake commented at 12:28 pm on November 6, 2016: member

   This needs a rebase.
7. 
   sipa commented at 2:03 am on November 7, 2016: member

   @fanquake Planning to rebase this after #8580, which I’ll rebase after #9039.
8. sipa force-pushed on Nov 13, 2016
9. sipa force-pushed on Nov 13, 2016
10. sipa force-pushed on Nov 13, 2016
11. 
    sipa commented at 0:19 am on November 14, 2016: member

    Rebased on top of the new #8580.
12. sipa force-pushed on Nov 15, 2016
13. sipa force-pushed on Nov 20, 2016
14. sipa force-pushed on Nov 22, 2016
15. sipa force-pushed on Nov 30, 2016
16. sipa force-pushed on Dec 1, 2016
17. sipa force-pushed on Dec 1, 2016
18. sipa force-pushed on Dec 1, 2016
19. sipa force-pushed on Dec 3, 2016
20. Move CTxInWitness inside CTxIn f6fb7acda4
21. sipa force-pushed on Dec 5, 2016
22. sipa renamed this:
    Inline CTxInWitness inside CTxIn (on top of #8580)
    Inline CTxInWitness inside CTxIn
    on Dec 5, 2016
23. 
    sipa commented at 8:26 am on December 5, 2016: member

    Rebased now #8580 is merged. Removes 80 lines of code!
24. 
    laanwj commented at 12:24 pm on December 8, 2016: member

    Testing #8589 #9283 #9288 #9589 on a reasonably busy public node.
25. 
    sipa commented at 5:53 pm on December 9, 2016: member

    I am curious what this myhtical #9589 is!
26. 
    gmaxwell commented at 8:23 pm on December 12, 2016: contributor

    ACK
27. 
    paveljanik commented at 9:58 pm on December 12, 2016: contributor

    Compiles cleanly utACK https://github.com/bitcoin/bitcoin/pull/8589/commits/f6fb7acda4aefd01b8ef6cd77063bfc0c4f4ab36
28. 
    laanwj commented at 12:56 pm on December 21, 2016: member

    I am curious what this myhtical #9589 is!

    #9289, sorry :)

29. 
    laanwj commented at 1:00 pm on December 21, 2016: member

    Slightly-tested ACK f6fb7ac
30. laanwj merged this on Dec 21, 2016
31. laanwj closed this on Dec 21, 2016

    ---

32. laanwj referenced this in commit e8cfe1ee2d on Dec 21, 2016
33. 
    morcos commented at 2:55 pm on December 21, 2016: member

    so much better thanks!
34. MarcoFalke referenced this in commit c65c77c721 on Apr 25, 2019
35. sidhujag referenced this in commit fd6ff32bc6 on Apr 27, 2019
36. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa fanquake laanwj gmaxwell paveljanik morcos

Labels
Refactoring