[qa]: remove root test directory for RPC tests #8652

pull rodentrabies wants to merge 2 commits into bitcoin:master from rodentrabies:cleanup changing 2 files +7 −4

rodentrabies commented at 9:47 AM on September 2, 2016: contributor

Fix for #8647. Back up each test's root directory and at the end if it is empty (or contains only *.bak) files, remove it too.
fanquake added the label Tests on Sep 2, 2016

fanquake commented at 12:00 PM on September 2, 2016: member

Travis output:

wallet-hd.py:
...
Stopping nodes
Cleaning up
stderr:
 Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/wallet-hd.py", line 87, in <module>
    WalletHDTest().main ()
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 185, in main
    os.rmdir(self.options.root)
OSError: [Errno 39] Directory not empty: '/tmp/test02xnhitc'
Pass: False, Duration: 34 s

rodentrabies commented at 1:34 PM on September 2, 2016: contributor

Sorry, accidentally used non-recursive directory removal.
rodentrabies force-pushed on Sep 2, 2016
MarcoFalke commented at 12:18 PM on September 4, 2016: member

Please don't delete the dir when there are files left. (The bak file should be properly removed in the corresponding test, which may be wallet-dump.py)
remove root test directory for RPC tests 438e94dc33
fix path for bak file c62cc4ec75
rodentrabies force-pushed on Sep 4, 2016
rodentrabies commented at 11:29 PM on September 4, 2016: contributor

@MarcoFalke Well, I didn't quite understand the problem with bak file, so decided it is that way for some purpose. L - Laziness... It appears that the bak file name was appended to test root without '/' separator. Fixed in c62cc4ec759a8487373f158b3cbb888efcdd753a.
MarcoFalke commented at 10:52 PM on September 9, 2016: member

utACK c62cc4ec759a8487373f158b3cbb888efcdd753a
MarcoFalke merged this on Sep 13, 2016
MarcoFalke closed this on Sep 13, 2016
MarcoFalke referenced this in commit 7fe6c5c993 on Sep 13, 2016
MarcoFalke commented at 10:10 AM on September 13, 2016: member

This will delete the dir when the user passed it in and it was empty in the beginning.

Though, overall I think this is better than the previous situation.
rodentrabies deleted the branch on Sep 13, 2016
MarcoFalke referenced this in commit 63462c2b4b on Sep 16, 2016
codablock referenced this in commit b64fcbd302 on Sep 19, 2017
codablock referenced this in commit 93e857ed9c on Jan 11, 2018
andvgal referenced this in commit 0121760c25 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8647 [qa] Cleanup doesn't get top level directory