1. 
   JeremyRubin commented at 8:38 pm on September 6, 2016: contributor

   Tests are really slow because of BOOST_CHECK doing a lot of unnecessary things in wine, BOOST_CHECK can’t just be ripped out because some people rely on certain features for there dev process.

   In lieu of a more permanent fix, this PR minimally modifies PrevectorTests to use a local check. To make sure this local check isn’t useless, it gets the seeds from the insecure random to allow tests to be repeated.

   This should be an easy to merge PR; discussion about generally improving the unit test performance/framework beyond this can go here: #8670

2. Minimal fix to slow prevector tests as stopgap measure f71d4a3786
3. 
   JeremyRubin commented at 8:49 pm on September 6, 2016: contributor

   Benchmarks

   On my local machine on a 32-bit win build running just PrevectorTests goes from taking 4 minutes + 24 seconds to 1.2 seconds with this patch.

4. 
   sipa commented at 8:56 pm on September 6, 2016: member

   Concept ACK
5. 
   TheBlueMatt commented at 9:43 pm on September 6, 2016: member

   utACK
6. fanquake added the label Tests on Sep 7, 2016
7. 
   dcousens commented at 2:55 am on September 7, 2016: contributor

   concept ACk
8. 
   JeremyRubin commented at 3:35 am on September 7, 2016: contributor

   Travis Benchmarks

   Comparing this build to the head build time for make check to run:

   Job 2 (i686-w64-mingw32)

   678s→337s

   data:

   https://travis-ci.org/bitcoin/bitcoin/jobs/157997974 https://travis-ci.org/bitcoin/bitcoin/jobs/157884494

   Job 4 (x86_64-w64-mingw32)

   529s→196s

   data:

   https://travis-ci.org/bitcoin/bitcoin/jobs/157997976 https://travis-ci.org/bitcoin/bitcoin/jobs/157884498

9. 
   jonasschnelli commented at 6:21 am on September 7, 2016: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/8671/commits/f71d4a3786611d564e4c239099501daee989b170
10. 
    MarcoFalke commented at 6:32 pm on September 7, 2016: member

    Thanks! utACK f71d4a3786611d564e4c239099501daee989b170
11. MarcoFalke merged this on Sep 8, 2016
12. MarcoFalke closed this on Sep 8, 2016

    ---

13. MarcoFalke referenced this in commit ddc308068d on Sep 8, 2016
14. furszy referenced this in commit 07b88da888 on Jan 25, 2021
15. zkbot referenced this in commit cd00fb08d5 on Feb 17, 2021
16. MarcoFalke locked this on Sep 8, 2021

Contributors
JeremyRubin sipa TheBlueMatt dcousens jonasschnelli MarcoFalke

Labels
Tests