Trivial: Fix obvious assignment/equality error in test #8673

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:fix_arith_tests_trivial changing 1 files +1 −1

JeremyRubin commented at 8:56 PM on September 6, 2016: contributor

I think this was incorrect; may as well correct it.
Fix obvious assignment/equality error in test 426e7bce0e
sipa commented at 8:58 PM on September 6, 2016: member

utACK
fanquake added the label Tests on Sep 7, 2016

fanquake commented at 2:16 AM on September 7, 2016: member

The Travis failure is unrelated.

segwit.py:
Initializing test directory /tmp/testa3q5cowz/31
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
Verify sigops are counted in GBT with pre-BIP141 rules before the fork
Assertion failed: 199.99600000 != 999.980
Stopping nodes
Not cleaning up dir /tmp/testa3q5cowz/31
Failed
stderr:
   File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 150, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/segwit.py", line 166, in run_test
    assert_equal(self.nodes[2].getbalance(), 20*Decimal("49.999"))
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/util.py", line 504, in assert_equal
    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Pass: False, Duration: 3 s

dcousens commented at 2:23 AM on September 7, 2016: contributor

utACK 426e7bc
paveljanik commented at 5:28 AM on September 7, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/commit/426e7bce0e365e0947f932ca46bcc48ca3a2f10e
MarcoFalke commented at 5:36 PM on September 7, 2016: member

Good catch! utACK 426e7bc
MarcoFalke merged this on Sep 7, 2016
MarcoFalke closed this on Sep 7, 2016
MarcoFalke referenced this in commit ec139a5621 on Sep 7, 2016
luke-jr commented at 10:00 AM on September 10, 2016: member

Is there any trick to make things like this case fail to compile?
JeremyRubin commented at 2:43 AM on September 13, 2016: contributor

@luke-jr I think -Wparentheses?
luke-jr referenced this in commit 03b01966fa on Sep 21, 2016
codablock referenced this in commit 7eddb40ce5 on Sep 19, 2017
codablock referenced this in commit 13a5c83293 on Jan 9, 2018
codablock referenced this in commit 3d26438bec on Jan 9, 2018
lateminer referenced this in commit a638b3764c on Nov 11, 2018
andvgal referenced this in commit fd4e72d4a1 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels