[0.13] Various backports #8679

sipa commented at 2:46 PM on September 7, 2016: member

This includes backports of #8520 #8540 #8282 #7579 #8624 #8604 #8291 #8524 #8612 #8651 #8606 #8594.

build: Remove check for `openssl/ec.h`

We don't use any elliptic curves from OpenSSL anymore, nor include this
header anywhere but optionally in the tests of secp256k1 (which has
its own autoconf setup).

Reported by sinetek on IRC.

75f2065293

qt: Fix random segfault when closing "Choose data directory" dialog

The `pickDataDirectory()` function was calling `exit(0)` to quit
the application when the user closes the dialog without choosing
a data directory.

This is a bad idea because a background thread is created (to
check free space on the drive of the currently selected datadir).
The thread is not stopped and unwound properly, resulting in a potential
race condition somewhere deep in Qt.

So replace the `exit()` by a boolean return value, and let the
stack unwind normally.

1db3352cc6

Added feeler connections increasing good addrs in the tried table.

Tests if addresses are online or offline by briefly connecting to them. These short lived connections are referred to as feeler connections. Feeler connections are designed to increase the number of fresh online addresses in tried by selecting and connecting to addresses in new. One feeler connection is attempted on average once every two minutes.

This change was suggested as Countermeasure 4 in
Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman,
Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report
2015/263. March 2015.

2611ad79a5

[Qt] show network/chain errors in the GUI f1c0d78b2d

[doc] build: Mention curl 0e6d753584

build: Updates for OpenBSD

- LevelDB platform was not guessed correctly (it ended up defining
  `-DOS_OPENBSD59` instead of `-DOS_OPENBSD`)

- On OpenBSD there is no convenience link from `python3.5` to `python3`:
  add detection for other python interpreter names.

- If it has to guess the LevelDB OS, print a autoconf warning so that
  the user can check.

b09e13cb6f

doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9

- Python 3 now supported.

- Bump boost version to 1.61 - one boost patch no longer needed.

- All checked with OpenBSD 5.9, except for the clang part, I left this
  as-is for someone adventurous.

- Mention overriding resource limits, OpenBSD's default ulimit does not
  suffice for building Bitcoin Core with gcc 4.9.3.

32d75a7ffc

[util] CopyrightHolders: Check for untranslated substitution

Also, remove check which is always true

a9874310c0

Precompute sighashes

Original version by Nicolas Dorier. Precomputing version by Pieter Wuille.

b8c79a057c

Check for compatibility with download in FindNextBlocksToDownload 2215c22a00

Fix some locks

This makes sure that cs_filter is never held while taking cs_main
or CNode::cs_vSend.

bbf379b055

Do not add random inbound peers to addrman.

We should learn about new peers via address messages.

An inbound peer connecting to us tells us nothing about
 its ability to accept incoming connections from us, so
 we shouldn't assume that we can connect to it based on
 this.

The vast majority of nodes on the network do not accept
 incoming connections, adding them will only slow down
 the process of making a successful connection in the
 future.

Nodes which have configured themselves to not announce would prefer we
 not violate their privacy by announcing them in GETADDR responses.

ab295bb4be

sipa added the label Backport on Sep 7, 2016

fanquake added this to the milestone 0.13.1 on Sep 7, 2016