Remove old manpages from contrib/debian in favour of doc/man #8743

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove-old-manpages changing 11 files +9 −100

fanquake commented at 4:41 AM on September 16, 2016: member

Removes the old manpages from contrib/debian/manpages, in favour of the newer ones in doc/man. Also adds a note about updating the manpages to release-process.md

Pinging @TheBlueMatt, would you be able to look this look this over and point out any fixes.

Fixes #8711
fanquake added the label Docs and Output on Sep 16, 2016
MarcoFalke commented at 7:34 AM on September 16, 2016: member

utACK 365c0920e89635f0605a1e604f489b363538a987

in contrib/debian/bitcoind.manpages:None in 365c0920e8 outdated

   0 | @@ -1,3 +1,4 @@
   1 | -debian/manpages/bitcoind.1
   2 | -debian/manpages/bitcoin.conf.5
   3 | -debian/manpages/bitcoin-cli.1
   4 | +doc/man/bitcoind.1
   5 | +doc/man/bitcoin-cli.1
   6 | +doc/man/bitcoin-qt.1

TheBlueMatt commented at 1:18 PM on September 16, 2016:

This should be in a contrib/debian/bitcoin-qt.manpages (and similarly for bitcoin-tx)

in contrib/debian/rules:None in 365c0920e8 outdated
```
   5 | @@ -6,7 +6,7 @@
   6 |  #	$(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),,src/test_bitcoin)
   7 |  
   8 |  DEB_INSTALL_EXAMPLES_bitcoind += debian/examples/*
   9 | -DEB_INSTALL_MANPAGES_bitcoind += debian/manpages/*
  10 | +DEB_INSTALL_MANPAGES_bitcoind += doc/man/*
```
TheBlueMatt commented at 1:22 PM on September 16, 2016:

Actually, these two lines should just be wholesale removed, I believe.

laanwj commented at 5:01 AM on September 22, 2016:

I think so too - make install installs the man pages, there's no need for debian to do anything special.

TheBlueMatt commented at 2:13 PM on September 22, 2016:

No, mostly this is a flag for a build method that we dont use - so these variables are just entirely ignored :).
laanwj commented at 2:18 PM on September 20, 2016: member

utACK after fixing @thebluematt's nits
laanwj commented at 2:38 PM on September 22, 2016: member

@fanquake I've added a commit that fixes @TheBlueMatt 's comments. If this change is okay we should squash and merge this.
Remove old manpages from contrib/debian b1948723c9
laanwj force-pushed on Sep 25, 2016
laanwj merged this on Sep 25, 2016
laanwj closed this on Sep 25, 2016
laanwj referenced this in commit bae178f3ca on Sep 25, 2016
fanquake commented at 6:12 AM on September 26, 2016: member

@laanwj Thanks for fixing this up, I haven't had access to push the changes.
fanquake deleted the branch on Sep 26, 2016
codablock referenced this in commit 3e3c00587b on Jan 19, 2018
codablock referenced this in commit c5fdd27d40 on Jan 23, 2018
andvgal referenced this in commit 317fa8fff3 on Jan 6, 2019
CryptoCentric referenced this in commit 85fa7be046 on Feb 27, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8711 Duplicate man pages