[0.13] Backports #8866

MarcoFalke commented at 9:03 AM on October 3, 2016: member

Several test and rpc related backports. (Minor non blocking fixes)

Created with the backport script by @luke-jr

Ping regularly in p2p-segwit.py to keep connection alive

This pings regularly while building a big block in p2p-segwit.py, to prevent timeout

Github-Pull: #8803
Rebased-From: 0637b02fce04c800acc6747687c91c9b22f642e5

375437c26b

[qa] Split up slow RPC calls to avoid pruning test timeouts

Github-Pull: #8827
Rebased-From: a0f8482f3e9b07e37c3f1b6fa09683b448810955

9bbe66e592

Add bitcoin-tx JSON tests

Github-Pull: #8829
Rebased-From: 54e5d7c1b81e1b76f5789abfa2cb1f5963cd9d72

2a8bca465d

[Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds

Github-Pull: #8765
Rebased-From: c6f5ca822f1308983431bf1b3c91f8aaccff51a0

62886598db

[rpc] throw JSONRPCError when utxo set can not be read

Github-Pull: #8832
Rebased-From: fa05cfdf256f3bc13b89ea80231e342f4302d204

83ad563ade

[qa] blockstore: Switch to dumb dbm

Github-Pull: #8834
Rebased-From: fa9cd25ed0587078e3218965606c79ebf8138d53

1dd1783873

[qa] nulldummy: Don't run unused code

Github-Pull: #8835
Rebased-From: fa156c604e7d86d84f7731b05d7530bc91d2736b

d87227d6d2

bitcoin-util-test.py should fail if the output file is empty

Github-Pull: #8836
Rebased-From: da9469770847df56e67e629986129a087b5bd7a5

eb18cc1272

test: Avoid ConnectionResetErrors during RPC tests

This is necessary on FreeBSD and MacOSX, at least.

See https://github.com/bitcoin/bitcoin/pull/8834#issuecomment-250450213

Github-Pull: #8839
Rebased-From: 1d28faf9e94fcf240ece7336d61ec297b064bc37

31ab2f862a

Fix nulldummy.py test

Github-Pull: #8841
Rebased-From: 46a4774d2bb9cc863e43507212ef989fa10d56d4

3e4abb5025

[qa] Fix race condition in p2p-compactblocks test

Also fix a bug in the sync_with_ping() helper function

Github-Pull: #8854
Rebased-From: b5fd666984fdb7125cb809c773b36034f32128cc

624a007f47

[qa] mininode: Only allow named args in wait_until

Github-Pull: #8857
Rebased-From: fa666094cf5b9ac4a7c1732a7ffa001afffcd938

1f60d45504

MarcoFalke added the label Tests on Oct 3, 2016

MarcoFalke added the label RPC/REST/ZMQ on Oct 3, 2016

laanwj added the label Backport on Oct 3, 2016

laanwj added this to the milestone 0.13.1 on Oct 3, 2016

MarcoFalke force-pushed on Oct 3, 2016

[qa] Add getinfo smoke tests and rework versionbits test

Github-Pull: #8780
Rebased-From: fa6e71b27d00766897f3e69775d450924a58a153

794b007896

[qa] util: Move wait_bitcoinds() into stop_nodes()

Github-Pull: #8860
Rebased-From: fa7c35c4ec630838178b4674288da33561a66f08

0bee740845

test: Explicitly set encoding to utf8 when opening text files

These are text files but their encoding does not depend on the locale.
Not all of them require utf8 but it is better to fix it at something
to remove potential unpredictability.

This is necessary on FreeBSD where no locale is set by default,
and apparently Python defaults not only the terminal encoding to the locale
but that of every text file. So without LOCALE environment it defaults text
file encoding to ASCII. This causes problems with e.g. `bitcoin.conf`.

Luckily the locale doesn't affect the default encoding for str.encode() and
bytes.decode() on Python 3, so this is the only change necessary.

Github-Pull: #8840
Rebased-From: 30930e847e2483c7c8163cc581b392bc288250e9

cbc3fe59c4

fanquake commented at 3:55 AM on October 5, 2016: member

This should wait for #8882 given that #8854 is included.

Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block

Github-Pull: #8884
Rebased-From: a78e5428acb862bfb47e6faff39f4889f5c73269

b987348435

[qa] Another attempt to fix race condition in p2p-compactblocks.py

sync_with_ping() only guarantees that the node has processed messages
it's received from the peer, not that block announcements from the node have
made it back to the peer.  Replace sync_with_ping() with an explicit check that
the node's tip has been announced.

Github-Pull: #8882
Rebased-From: 6976db2f4687d575e1b4bee5aaf1d93a794f23c3

b73f0653f3

[qa] Fix race condition in sendheaders.py

Also de-duplicates code that has been moved to mininode

Github-Pull: #8882
Rebased-From: b55d9411e7e1aa36ddabba3b942f2e1c736c1bd9

d6c83b95cf

[Doc] Update bips.md for Segregated Witness

Github-Pull: #8891
Rebased-From: ef28d8a899aeb4487ef7fbfbfca9c0f2b60bdaf6

5e0dd9e07c

MarcoFalke added the label Docs and Output on Oct 8, 2016

instagibbs commented at 1:57 PM on October 10, 2016: member

Diff review ACK https://github.com/bitcoin/bitcoin/pull/8866/commits/5e0dd9e07c02422a263cc14a173d4ee21a7c1393

(only text that is different is the getinfo deprecation non-backport in tests)

fanquake commented at 2:28 PM on October 10, 2016: member

Also reviewed the diffs. Only difference is text in https://github.com/bitcoin/bitcoin/pull/8866/commits/794b007896aae7b180bdfc771bb4e1656a3e3329 vs https://github.com/MarcoFalke/bitcoin/commit/fa6e71b27d00766897f3e69775d450924a58a153

ACK https://github.com/bitcoin/bitcoin/pull/8866/commits/5e0dd9e07c02422a263cc14a173d4ee21a7c1393

MarcoFalke assigned laanwj on Oct 11, 2016

MarcoFalke commented at 9:07 AM on October 11, 2016: member

I think those are all the qa/rpc/doc changes for 0.13.1; This should be ready now.

laanwj commented at 9:32 AM on October 11, 2016: member

Yes, this is ready. Can't merge it though while I'm in Milan so feel free to do so.

MarcoFalke merged this on Oct 11, 2016

MarcoFalke closed this on Oct 11, 2016

MarcoFalke referenced this in commit 94688d8e43 on Oct 11, 2016

MarcoFalke deleted the branch on Oct 11, 2016

MarcoFalke locked this on Sep 8, 2021