testing pr (please ignore) #9018

pull ryanofsky wants to merge 13 commits into bitcoin:master from ryanofsky:loop changing 13 files +31 −83

ryanofsky commented at 9:48 PM on October 25, 2016: member

No description provided.

[qa] Fix bug in compactblocks v2 merge

Bug caused the wait_for_block_announcement to be called on the wrong node,
leading to nondeterminism and occasional test failures. Bug was introduced in
merge commit:

d075479 Merge #8882: [qa] Fix race conditions in p2p-compactblocks.py and sendheaders.py

Underlying commits which conflicted were:

27acfc1 [qa] Update p2p-compactblocks.py for compactblocks v2
6976db2 [qa] Another attempt to fix race condition in p2p-compactblocks.py

The first commit changed the test_compactblock_construction function signature
and second commit added code which wasn't updated during the merge to use the
new arguments.

Suhas Daftuar <sdaftuar@chaincode.com> noticed the bug and suggested the fix.

186bd1de8e

[qa] Improve sync_blocks error messages. fd9a17bd35

[qa] Fix sync_blocks timeout argument

Motivation for this change is mainly to make sync_blocks behavior easier to
understand. Behavior is unchanged in the normal case when there are only 2
nodes in the rpc_connections set. When there are more than 2 nodes, the
previous "timeout -= wait" statement wouldn't take into account time spent
waiting for all nodes and as a result could lead to blocking for longer than
the requested timeout.

e04005c6ff

Send tip change notification from invalidblock

Change suggested by Suhas Daftuar <sdaftuar@chaincode.com>
at https://github.com/bitcoin/bitcoin/pull/8680#r78209060

51a8ff99ce

[qa] Change sync_blocks to pick smarter maxheight

Instead of syncing to max height returned by the waitforblockheight RPC, sync
to the max height returned by the getblockcount RPC.

This change was suggested by Suhas Daftuar <sdaftuar@chaincode.com>.

This change requires a seperate fix to InvalidateBlock ("Send tip change
notification from invalidblock") to avoid a sync failures in the mempool_reorg
test, which uses the invalidateblock RPC.

7c2cccb3e6

[qa] Avoid 2 list comprehensions in sync_blocks eeccaef0f9
disable unneeded tests f9d4891620
loop ad468f212b
loop 7e43205f6a
loop e54b9259d1
loop e03fd2b96f
loop 775b398fe9
sipa commented at 10:48 PM on October 25, 2016: member

What is this?
loop d402c5470a
sipa commented at 10:59 PM on October 25, 2016: member

Please stop spamming.
sipa closed this on Oct 25, 2016
TheBlueMatt commented at 1:54 PM on October 26, 2016: member

Thats my bad, I told him if he wants to test travis he can just open a pr and keep updating till the tests pass...I forgot that github started sending emails for each push.
jnewbery commented at 2:02 PM on October 26, 2016: member

@TheBlueMatt - if @ryanofsky's Bitcoin fork is public, he should be able to enable Travis builds on the branches in his own fork.
DrahtBot locked this on Sep 8, 2021

Contributors