there was only one instance of 'mem pool' and not 'mempool', so I changed it to conform to the others
instance of 'mem pool' to 'mempool' #9029
pull smatthewenglish wants to merge 1 commits into bitcoin:master from smatthewenglish:patch-7 changing 2 files +2 −2-
smatthewenglish commented at 10:13 AM on October 27, 2016: contributor
-
laanwj commented at 10:50 AM on October 27, 2016: member
Makes sense, utACK
-
paveljanik commented at 11:15 AM on October 27, 2016: contributor
Not the only one, please fix also the second one in
src/rpc/mining.cpp. -
MarcoFalke commented at 11:56 AM on October 27, 2016: member
I was once wondering if this should be changed to transaction pool, but I don't think it is feasible to change at this point.
- MarcoFalke added the label Docs and Output on Oct 27, 2016
-
laanwj commented at 12:47 PM on October 27, 2016: member
Yes, in retrospect that would have been a much better name. But everyone knows what a mempool is by now, changing it will just seed more confusion. Better to go with the least invasive change.
-
smatthewenglish commented at 1:02 PM on October 27, 2016: contributor
ok- I changed that one in
src/rpc/mining.cpp, the changes are on the same branchpatch-7but now I guess I should squash the commits? is it so?Can I squash commits using the GitHub web app? If not I can do it from my console but not until later this evening.
I agree that mempool is kind of standard jargon, it's in the "Mastering Bitcoin" book by Andreas Antonopoulos for instance
-
1c3ecc70c8
instance of 'mem pool' to 'mempool'
there was only one instance of 'mem pool' and not 'mempool', so I changed it to conform to the others
- laanwj force-pushed on Oct 27, 2016
-
laanwj commented at 2:46 PM on October 27, 2016: member
Squashed the commits
- laanwj merged this on Oct 27, 2016
- laanwj closed this on Oct 27, 2016
- laanwj referenced this in commit fea5e05a63 on Oct 27, 2016
-
fanquake commented at 3:42 PM on October 27, 2016: member
utACK
On Thursday, 27 October 2016, Wladimir J. van der Laan < notifications@github.com> wrote:
Makes sense, utACK
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub #9029 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA0t8ktEH6WL21dlgOmHD2TsY-3qCbfiks5q4IHsgaJpZM4KiLCN .
- luke-jr referenced this in commit b1e978cfd6 on Dec 2, 2016
- codablock referenced this in commit ebe8501824 on Sep 19, 2017
- codablock referenced this in commit 01389bc330 on Jan 13, 2018
- andvgal referenced this in commit 061d8e3211 on Jan 6, 2019
- CryptoCentric referenced this in commit bf442f95c8 on Feb 15, 2019
- DrahtBot locked this on Sep 8, 2021
Labels