Apologies for code churn, but I've updated almost all of the code in these files, so I thought I might as well tidy up the code:
change tabs for spaces, to align with convention in other py files
Oh yes that was irking me, had to change editor settings all the time just for that file. utACK https://github.com/bitcoin/bitcoin/pull/9069/commits/dd76c14977eafc7f09f98f4b40475970c7c74845
16 | @@ -16,11 +17,13 @@ 17 | 18 | Can also be run manually from the src directory by specifiying the source directory: 19 | 20 | -test/bitcoin-util-test.py --src=[srcdir] 21 | +test/bitcoin-util-test.py --src='srcdir' [--verbose]
I think this comment is wrong, too? It looks for --srcdir not --src.
Good spot. Thanks.
- remove newlines
- change tabs for spaces, to align with convention in other py files
- add comments
- add 'Bitcoin Core Developers' copyright notice
16 | - return json.loads(a) 17 | - elif fmt == 'hex': # hex: parse and compare binary data 18 | - return binascii.a2b_hex(a.strip()) 19 | - else: 20 | - raise NotImplementedError("Don't know how to compare %s" % fmt) 21 | + """Parse the output a with format fmt. fmt can either be hex or json.
µNit: no need to mention what fmt can be, when it is mentioned in the code just a line below.
µACK. Comment shortened.
Nits addressed and commits squashed.
utACK https://github.com/bitcoin/bitcoin/pull/9069/commits/2b175d4b018be432e333bf8a343b85c5f284264f The non-whitespace diff is seen with ?w=1.