[depends] Set OSX_MIN_VERSION to 10.8 #9114

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends-min-osx-10-8 changing 1 files +1 −1

fanquake commented at 11:00 AM on November 9, 2016: member

0.13.0 is no longer compatible with OS X 10.7, see discussion in this thread, and a plist change was made to prevent bitcoin-core running on 10.7 systems.

Earlier discussion mentioned that once we set the minimum target version to 10.8, we could remove some OS X related hacks, particularly in macnotificationhandler.mm, so that could now be revisited.
[depends] Set OSX_MIN_VERSION to 10.8 617c96d5b3
fanquake added the label Build system on Nov 9, 2016
laanwj commented at 11:31 AM on November 9, 2016: member

Concept ACK
jonasschnelli commented at 12:39 PM on November 9, 2016: contributor

ACK 617c96d5b3dd1b4665edff80913f473635ed0efb
paveljanik commented at 5:42 PM on November 9, 2016: contributor

Concept ACK
theuni commented at 5:07 PM on November 10, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/9114/commits/617c96d5b3dd1b4665edff80913f473635ed0efb

fanquake commented at 4:57 AM on November 11, 2016: member

A bit more info about this. If you generate a depends prefix on OS X 10.12, and then plug that into configure, ./configure --prefix=/Users/michael/Github/bitcoin/depends/x86_64-apple-darwin16.1.0, when you compile it will fail with:

In file included from httpserver.cpp:22:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1162:1: error: 'future<bool>' is unavailable: introduced in macOS 10.8
future<_Rp>::~future()

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1896:1: error: '__packaged_task_function<bool (event_base *, evhttp *)>' is unavailable: introduced in macOS 10.8
__packaged_task_function<_Rp(_ArgTypes...)>::__packaged_task_function(_Fp&& __f)

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:632:1: error: '__assoc_state<bool>' is unavailable: introduced in macOS 10.8
__assoc_state<_Rp>::__on_zero_shared() _NOEXCEPT

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1455:1: error: 'promise<bool>' is unavailable: introduced in macOS 10.8
promise<_Rp>::get_future()

18 errors generated.

After this change it compiles.

laanwj merged this on Nov 11, 2016
laanwj closed this on Nov 11, 2016
laanwj referenced this in commit 21e6c6b569 on Nov 11, 2016
fanquake deleted the branch on Nov 11, 2016
zkbot referenced this in commit 33f7145fb2 on Nov 29, 2017
zkbot referenced this in commit b2399c1951 on Nov 30, 2017
zkbot referenced this in commit d3ca2706a8 on Nov 30, 2017
zkbot referenced this in commit 02c4467cb5 on Nov 30, 2017
codablock referenced this in commit 4bb2af8d19 on Feb 7, 2018
CryptoCentric referenced this in commit 0f0206dc3b on Feb 28, 2019
CryptoCentric referenced this in commit 0bf799354b on Mar 2, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8184 WIP: OSX toolchain bump #8577 0.13.0 is no longer compatible with OSX 10.7