Depends built QT isn't being properly picked up on OS X #9126

If you do a depends build on OS X (10.12), and plug the result into configure ./configure --prefix=/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.1.0 no bitcoin-qt is built.

checking for QT... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... yes
checking for QTPLATFORM... yes
checking for QTPRINT... yes
checking for Qt < 5.4... no
checking whether the linker accepts -framework IOKit... yes
checking for static Qt plugins: -lqcocoa... no
configure: WARNING: Could not resolve: -lqcocoa; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no (Qt5)

QT parts from config.log are below. config.txt

Retested this on OSX 10.12.2, still seeing the same result.

./configure --prefix=/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0

Options used to compile and link:
  with wallet   = yes
  with gui / qt = no
  with zmq      = yes
  with test     = yes
  with bench    = yes
  with upnp     = yes
  debug enabled = no

  target os     = darwin
  build os      = darwin

  CC            = /Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -mmacosx-version-min=10.8
  CFLAGS        = -pipe -O2 
  CPPFLAGS      = -Qunused-arguments -I/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX
  CXX           = /Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11
  CXXFLAGS      = -pipe -O2 
  LDFLAGS       = -L/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../lib  -Wl,-headerpad_max_install_names -Wl,-dead_strip

Is this still an issue with qt5.7.1 ?

@theuni Looks like it is. This is with master on 10.12.2:

./configure --prefix=/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0

checking for QT... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... yes
checking for QTPLATFORM... yes
checking for QTPRINT... yes
checking for Qt < 5.4... no
checking whether the linker accepts -framework IOKit... yes
checking for static Qt plugins: -lqcocoa... no
configure: WARNING: Could not resolve: -lqcocoa; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no (Qt5)

Options used to compile and link:
  with wallet   = yes
  with gui / qt = no
  with zmq      = yes
  with test     = yes
  with bench    = yes
  with upnp     = yes
  debug enabled = no

  target os     = darwin
  build os      = darwin

  CC            = /Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -mmacosx-version-min=10.8
  CFLAGS        = -pipe -O2 
  CPPFLAGS      = -Qunused-arguments -I/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DMAC_OSX
  CXX           = /Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../native/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -mmacosx-version-min=10.8 -stdlib=libc++ -std=c++11
  CXXFLAGS      = -pipe -O2 
  LDFLAGS       = -L/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.3.0/share/../lib  -Wl,-headerpad_max_install_names -Wl,-dead_strip

Ok, I'm having trouble navigate the qt buildsystem maze, but the issue is that the plugin isn't getting installed where we expect it to. Sadly, I added a hack rather than fixing properly for Linux, so we're seeing it for some reason here now too.

See https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk#L170

I think if we add the same thing for plugins/platforms/libqcocoa.a, it should work.

Had tried a build with this patch:

  if `test -f qtbase/src/plugins/platforms/libqcocoa.a`; then \
	cp qtbase/src/plugins/platforms/libqcocoa.a $($(package)_staging_prefix_dir)/lib; \
  fi

liqcocoa.a does get put into src/plugins/platforms, but that doesn't seem to fix the build. Will investigate further shortly.

Looking at this in bitcoin_qt.m4

      elif test x$TARGET_OS = xdarwin; then
        AX_CHECK_LINK_FLAG([[-framework IOKit]],[QT_LIBS="$QT_LIBS -framework IOKit"],[AC_MSG_ERROR(could not iokit framework)])
        _BITCOIN_QT_CHECK_STATIC_PLUGINS([Q_IMPORT_PLUGIN(QCocoaIntegrationPlugin)],[-lqcocoa])
        AC_DEFINE(QT_QPA_PLATFORM_COCOA, 1, [Define this symbol if the qt platform is cocoa])
      fi

@fanquake Can you see if https://github.com/theuni/bitcoin/commit/c81d0a3fb99296b9a3442ba86de2f25d2dc0c447 fixes for you?

@theuni on-top of my libcocoa patch?