[depends] Fix QT build on OSX #9574

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fix-osx-depends-build changing 2 files +2 −1

fanquake commented at 11:36 AM on January 18, 2017: member

This should be enough to fix the depends QT build on OSX.

cc @theuni

Fixes #9126
fanquake added the label Build system on Jan 18, 2017
fanquake added the label MacOSX on Jan 18, 2017
fanquake requested review from theuni on Jan 18, 2017
theuni commented at 1:39 PM on January 18, 2017: member

@fanquake Only the second was actually needed for me, is the libcocoa.a change necessary now that we aren't missing symbols? I kinda doubt it, since it's got a typo (p -> cp) :P
depends: qt: disable printer for all platforms, not just osx
This also fixes the native osx build.
c36ec715f0
fanquake force-pushed on Jan 19, 2017
fanquake commented at 7:41 AM on January 20, 2017: member

@theuni not sure how I ended up pushing the borked patch. I had one instance where it looked like I still needed the libcocoa.a change, but it seems that plugin has been there all along. Fixed this up to include only the printer changes.
theuni commented at 4:22 PM on January 20, 2017: member

Thanks for testing. ACK c36ec715f06d212381e0edfa4344514f1a575701
laanwj merged this on Jan 26, 2017
laanwj closed this on Jan 26, 2017
laanwj referenced this in commit 5ac668759d on Jan 26, 2017
fanquake deleted the branch on Jan 28, 2017
codablock referenced this in commit 4253e2954f on Jan 19, 2018
codablock referenced this in commit 7246b9ef2f on Jan 20, 2018
codablock referenced this in commit e09d5db455 on Jan 21, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

fanquake

theuni

Labels

macOS Build system

Linked (view graph)

#9126 Depends built QT isn't being properly picked up on OS X