Bring up the modal progress overlay when the user clicks the spinner icon in the task bar.
I think this is the intuitive thing to do when that icon is clicked.
qt: Show progress overlay when clicking spinner icon #9218
pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2016_11_overlay_when_clicking_sync_icon changing 4 files +39 −33-
laanwj commented at 1:40 PM on November 24, 2016: member
-
827d9a3be8
qt: Replace NetworkToggleStatusBarControl with generic ClickableLabel
Generalize the clickable label functionality. We will use this to add similar functionality to the sync icon.
-
042f9fa071
qt: Show progress overlay when clicking spinner icon
Bring up the modal progress overlay when the user clicks the spinner icon in the task bar. I think this is the intuitive thing to do when that icon is clicked.
- laanwj added the label GUI on Nov 24, 2016
-
jonasschnelli commented at 1:44 PM on November 24, 2016: contributor
Thanks for doing this! I think it would be great if the modal progress overlay would show when the users presses on the sync progress bar in the task-bar.
-
paveljanik commented at 2:11 PM on November 24, 2016: contributor
It makes sense in IBD, but later when you are in sync with the network, the info there is almost useless and false in fact.
-
laanwj commented at 2:30 PM on November 24, 2016: member
It makes sense in IBD, but later when you are in sync with the network, the info there is almost useless and false in fact.
Maybe it should only (ever) show during IBD and when catching up?
In any case I was looking for a way to show the progress overlay while not on the overview tab, and this seems to work...
I think it would be great if the modal progress overlay would show when the users presses on the sync progress bar in the task-bar.
Yeah why not that too.
-
sipa commented at 8:18 PM on November 24, 2016: member
Concept ACK
-
gmaxwell commented at 9:01 PM on November 24, 2016: contributor
Concept ACK.
Perhaps just make the text at the top of that overlay display conditionally. (And otherwise perhaps display "your node appears to be up to date. The most recent received block is 12345 with timestamp X which you recieved Y minutes ago."
-
fanquake commented at 4:30 AM on December 2, 2016: member
How this currently functions:
-
-
jonasschnelli commented at 7:51 PM on December 4, 2016: contributor
Tested ACK 042f9fa071fd76ab310cd47b73d0e620a7850660
- jonasschnelli merged this on Dec 4, 2016
- jonasschnelli closed this on Dec 4, 2016
- jonasschnelli referenced this in commit 4d955fc582 on Dec 4, 2016
-
paveljanik commented at 8:33 PM on December 4, 2016: contributor
This was merged a bit prematurely, I think.
The info present after being in sync with the network is nonsense. Just try it and imagine users reading it... Like "%n seconds(s)"
-
laanwj commented at 7:25 AM on December 5, 2016: member
Feel free to make it better. I wasn't intending to change the message in this pull, at least.
A simpler fix that I realized later is to only show it when the spinner is actually a spinner, and not when it is a "check" icon.
But I think this is ok for now, it's sort-of hidden functionality anyway.
-
paveljanik commented at 8:28 AM on December 5, 2016: contributor
A simpler fix that I realized later is to only show it when the spinner is actually a spinner, and not when it is a "check" icon.
This is exactly what is needed. Please PR it. Thank you.
-
jonasschnelli commented at 8:32 AM on December 5, 2016: contributor
Will try to add @paveljanik's/@laanwj's suggestions in #9280.
- codablock referenced this in commit e75838fcf6 on Sep 9, 2017
- codablock referenced this in commit 6336ac1acd on Sep 11, 2017
- UdjinM6 referenced this in commit 91d99fcd3f on Sep 11, 2017
- DrahtBot locked this on Sep 8, 2021
Labels